search

archilogic-com / aframe-gblock

Aframe component loading models from poly.google.com (inofficial)
MIT License
68 stars 14 forks source link

Please publish to npm #8

Open urish opened 6 years ago

urish commented 6 years ago

Most a-frame components are available on npm, it will be very useful to have this one as well!

Seems like you have already got a package.json file, and I suggest adding a files section as follows: 

"files": ["dist"],

This will make sure that only the dist folder will be published.

Thank you!

tomas-polach commented 6 years ago

@urish totally forgot about NPM :sweat_smile: - will do! thx!

urish commented 6 years ago

Thank you so much!

On Wed, May 2, 2018, 2:32 PM Tomas Polach notifications@github.com wrote:

@urish https://github.com/urish totally forgot about NPM 😅 - will do! thx!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/archilogic-com/aframe-gblock/issues/8#issuecomment-385947427, or mute the thread https://github.com/notifications/unsubscribe-auth/AA2dniD5_b2wy0FdwWlYRS3nltbYQdltks5tuZlggaJpZM4TlYia .

tomas-polach commented 6 years ago

You are always welcome! It's published now :tada:

Yourfiles section advice was very helpful. What do you think about moving all server code to a separate branch? It is not really needed when using the official API - thus, it might be cleaner to keep only the aframe component in master branch?

urish commented 6 years ago

That makes much sense. While at it, it'd also make sense to add a note to the README about the possibility to install from npm.

To celebrate this, I created a quick stackblitz demo utilizing the fresh npm package: https://stackblitz.com/edit/aframe-gblock?file=index.html 🎈

ghost commented 6 years ago

@tomas-polach i'm assigning this to you then for review and close