Scope JSON to global ruby ::JSON, prevents conflicts with Sinatra::JSON

archiloque / sinatra-swagger-exposer

Create Swagger endpoint for your Sinatra application

MIT License

15 stars 20 forks source link

Scope JSON to global ruby ::JSON, prevents conflicts with Sinatra::JSON #4

Closed gerbal closed 8 years ago

coveralls commented 8 years ago

Coverage remained the same at 99.06% when pulling e915d7f452dd67ea086d2e5eb71ac857faec1388 on gerbal:master into de1c2321b2a53abe263e55eac68df0042321c194 on archiloque:master.

brennovich commented 8 years ago

Hey, can this be merged? I'm having this issues too, and anyone using sinatra/json extension will face it as well.

gerbal commented 8 years ago

@archiloque could you merge this mate?

rbroemeling commented 8 years ago

@gerbal The PR as written covers the JSON usage in lib/sinatra/swagger-exposer/processing/swagger-response-processor.rb, but not the JSON usage in lib/sinatra/swagger-exposer/processing/swagger-request-processor.rb. Perhaps it should be updated before merged?

Credit to @brennovich for seeing this, I just noticed the difference between this PR and his work at https://github.com/brennovich/sinatra-swagger-exposer/commit/dd38ee5148197b5da2da2d82b7e48043d90f39d7 .

gerbal commented 8 years ago

We could just merge in brennovich@dd38ee5

archiloque commented 8 years ago

Sorry my notifications were broken, I'm having a look at it this week-end.