search

archimag / cl-closure-template

Common Lisp implementation of Google's Closure Templates.
Other
71 stars 23 forks source link

Relax conditions #4

Closed mishoo closed 12 years ago

mishoo commented 12 years ago

This includes my first pull request too. See the commit log for description.

archimag commented 12 years ago

Well, I like it, you could also add tests to check for this?

mishoo commented 12 years ago

Sure, could you provide some painless hints on how to run the test suite? I'm unfamiliar with these things... I see a system is already defined, I try to load like this:

(asdf:load-system "closure-template-test")

and it looks like it could work, but eventually I get an error:

The value
  #<SB-C::GLOBAL-VAR
    :%SOURCE-NAME CLOSURE-TEMPLATE:*DEFAULT-CLOSURE-TEMPLATE-PACKAGE*
    :WHERE-FROM :DECLARED
    :KIND :SPECIAL {1002C17AE1}>
is not of type
  (OR SB-C::LAMBDA-VAR CONS NULL).
   [Condition of type TYPE-ERROR]
archimag commented 12 years ago 
(asdf:load-system "closure-template")
(asdf:load-system "closure-template-test")
(closure-template.test:run-closure-template-tests)

or

(asdf:operate 'asdf:test-op '#:closure-template)

<SB-C::GLOBAL-VAR

Hmm... I know that some people still have problems with LIFT (http://common-lisp.net/project/lift/). What version of sbcl?

mishoo commented 12 years ago

Hmm... I know that some people still have problems with LIFT (http://common-lisp.net/project/lift/). What version of sbcl?

Yeah, it's the same error with asdf:test-op (thanks for the hint, BTW, I didn't know that). I'm with SBCL 1.0.50.43-6caf3ed

archimag commented 12 years ago

Try to take LIFT from here http://common-lisp.net/~sionescu/files/lift-1.7.0.tar.bz2

If the problem persists, then I'm do a merge now, but later I'll write the tests himself.

P.S. I am sorry for my English.

mishoo commented 12 years ago

I get a different error with that version of lift:

The function LIFT::TEST-NAME->METHODS is undefined.
   [Condition of type UNDEFINED-FUNCTION]

By the way, that seems an older version (the one I'm running currently is installed with Quicklisp and it's the latest at git://github.com/gwkkwg/lift ).