search

archimatetool / archi-modelrepository-plugin

coArchi - a plug-in to share and collaborate on Archi models.
152 stars 52 forks source link

Cmd line repo commit publish #163

Closed michaelansley closed 3 years ago

michaelansley commented 3 years ago

Updates to the repository plug-in to achieve the following:

  1. Separate UI from repository processes
  2. Add command-line options to commit, refresh and publish a repository model
  3. Add a command-line option to switch branch when loading/cloning a repository model
jbsarrodie commented 3 years ago

Hi,

Thank you for this.

Please note that the intended process for code submission is to first discuss the goal with Phil and I before actually working on it (in order to avoid wasting your time in case similar work is already started on our side or if we already discussed about a feature and decided not to add it) and then open a draft pull request. For a more detailed presentation of this, see this wiki page.

Phil and I been working on other features in Archi at the moment, we won't be able to look at your code anytime soon.

In addition, note that we've stopped working on this plugin and started a full rewrite named coArchi2 (not ready for production yet).

Regards,

JB

michaelansley commented 3 years ago

Hi JB,

You are right, of course, I should have discussed the PR with someone before posting it... it started out as something that I had no intention of posting, and when I got to the end, it seemed rather more worthwhile. Mea culpa, sorry.

Probably the best is to reject this PR... the code is already committed to my fork and available for perusal when the time is right (I've had some discussion with Phil already, and perhaps that time will arrive in the not-too-distant future).

Regards, Michael

Phillipus commented 3 years ago

@jbsarrodie I should have mentioned that @michaelansley and I have been discussing this off-line by email. As we noted, there are some useful ideas here that could input into the development of coArchi 2 when we get back to it.

@michaelansley I've looked at the code in the PR and can see the thinking behind it. As we discussed in email, the changes in coArchi 2 will be such that we should save this for then.

the code is already committed to my fork and available for perusal when the time is right

Agreed, so I'll close this PR just to tidy up here. Thanks!