search

archimatetool / archi-modelrepository-plugin

coArchi - a plug-in to share and collaborate on Archi models.
153 stars 52 forks source link

Skip SSL Verification Flag #164

Open pchar opened 3 years ago

pchar commented 3 years ago

Hi, I've added a simple flag to the clone dialog that allow tho add ex: [http "https://localhost:3000"] sslVerify = false into the $home/.gitconfig file this will skip the SSL handshake verification during the clone process, i've made this changes because in my current work environment was so easy to add the self signed CA root to the keystore

please also see the issue https://github.com/archimatetool/archi-modelrepository-plugin/issues/113

Let me know if you thing that culd be a usefull changes Regards

jbsarrodie commented 3 years ago

Hi,

Thank you for this.

Please note that the intended process for code submission is to first discuss the goal with Phil and I before actually working on it (in order to avoid wasting your time in case similar work is already started on our side or if we already discussed about a feature and decided not to add it) and then open a draft pull request. For a more detailed presentation of this, see this wiki page.

Phil and I been working on other features in Archi at the moment, we won't be able to look at your code anytime soon.

In addition, note that we've stopped working on this plugin and started a full rewrite named coArchi2 (not ready for production yet).

Regards,

JB

pchar commented 3 years ago

Hi JB, yes you are right but in this case I had to make a quick fix because we were blocked in our organisation and i had to make a quick fix to solve our situation. I submitted the patch because just to not waste the code and because there were an open issue on this topic

Phillipus commented 3 years ago

Thanks for sharing but as JB says we prefer to receive draft PRs as it makes it easier to discuss them.

In this case, for now, users can manually add the setting to the .gitconfig file so it's not urgent. When we restart work on coArchi 2 we might think of a way to make it easier to set this. Also, it might be something that a user might set per repository rather than globally.

pchar commented 3 years ago

Just for your info the path set the ssl ignore URL by URL so it focus on one specific repository not globally , but it's true that it write on the .gitconfig home