archimatetool / archi-modelrepository-plugin

coArchi - a plug-in to share and collaborate on Archi models.
151 stars 52 forks source link

github modern auth #198

Closed terryrankine-ffi closed 1 year ago

terryrankine-ffi commented 1 year ago

Version of Archi, Operating System

Windows - Latest build

Version of this plug-in

Windows - Latest Build

Any other plug-ins installed?

nope - clean

Expected Behaviour

I should be able to add a github url, I would get redirected for web-based modern auth, I would get the token for access, my connection would work.

Actual Behaviour

I get a http(s) basic auth popup which is incapable of working as github dropped support for modern auth

Steps to Reproduce the Behaviour

  1. import from a github url.

If this has been solved - I cant find it in your readme, and I cant find the load repo from disk but connect it to git either.

Not sure how its designed to work - but didnt meet my expectations.

terryrankine-ffi commented 1 year ago

https://github.blog/changelog/2021-08-12-git-password-authentication-is-shutting-down/

Phillipus commented 1 year ago

Please use a Personal Access Token for the HTTPS password.

https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/creating-a-personal-access-token

terryrankine-ffi commented 1 year ago

Isnt the fix to extend the UI to have (PAT) in brackets where it says password and the link to the github page on how to do that?

Noting that default search in github doesnt search closed tickets - i litterally didnt find the other 6? tickets which also mention this. Nor did I stumble on the already existing webpage.

I think there is a better fix than close to help reduce the frequency of this one

Phillipus commented 1 year ago

There are other git hosts than GitHub. They might or might not use a PAT and have different methods to create one. We have mentioned it on the wiki