archimatetool / archi

Archi: ArchiMate Modelling Tool
https://www.archimatetool.com
MIT License
927 stars 267 forks source link

Find function on "Find/Replace" form don't use "Case Sensitive" option with cirillic. #804

Closed margolyesh closed 2 years ago

margolyesh commented 2 years ago

Version of Archi

4.9.2

Archi Plug-ins

Archi Colloboration 0.8.0.2021110121448 Archi Scripting 1.2.0.2021110121451 Lightbox for Archi 1.1.1.20210807

Operating System

Win 10

Expected Behaviour

Find function on "Find/Replace" form don't use "Case Sensitive" option with cirillic.

Actual Behaviour

Positive scen. I have two Bussiness Actor elements: "Customer" and "customer". If "Case Sensitive" options hasn't activate on "Find/Replace" form and I searching "customer" or "Customer" then both element will be find. If "Case Sensitive" options has activate on "Find/Replace" form and I searching "customer" or "Customer" then one element element will be find.

Negative scen. I have two Bussiness Actor elements: "Клиент" and "клиент". If "Case Sensitive" options hasn't activate on "Find/Replace" form and I searching "клиент" or "Клиент" then one element element will be find. If "Case Sensitive" options has activate on "Find/Replace" form and I searching "клиент" or "Клиент" then one element element will be find.

Phillipus commented 2 years ago

Notes for investigation:

com.archimatetool.editor.ui.findreplace.AbstractFindReplaceProvider

Possible change to regex pattern in method getSearchStringPattern:

if(!isCaseSensitive()) {
    searchString = "(?i:" + searchString + ")"; 
}
Phillipus commented 2 years ago

Will be fixed for next version.

Phillipus commented 2 years ago

Fixed in next version