Closed jbsarrodie closed 1 year ago
In the spec the arc joins the arrow line so it is almost a circle, which is what I tried to do in my attempt:
In the spec the arc joins the arrow line so it is almost a circle
That's a "flaw" in the spec ;-) It shouldn't appear as a full circle (inspired from the agile sprint icon).
I choose version (2) and added a bit more of the arc. This seems (to me) the best compromise:
Next: tuning the full icon
I prefer this one:
;-)
I prefer the first one as it looks a bit more balanced.
Regard,
Andrew Greff
On Tuesday, January 10, 2023, Jean-Baptiste Sarrodie < @.***> wrote:
I'm tuning the workpackage small icon (the one used in the box notation) and came up with two variants:
1.
Based on the very first proposal https://media.licdn.com/dms/image/C4D2CAQFn1iqHgfhaIA/comment-image-shrink_8192_1280/0/1643634696862?e=1673956800&v=beta&t=3O3g4FHfpITfz848D1hW7U3vMil34reNYYHOYID9u4U I made on LinkedIn https://www.linkedin.com/feed/update/urn:li:groupPost:50758-6892858604165181440?commentUrn=urn%3Ali%3Acomment%3A%28groupPost%3A50758-6892858604165181440%2C6893903585911140352%29&dashCommentUrn=urn%3Ali%3Afsd_comment%3A%286893903585911140352%2Curn%3Ali%3AgroupPost%3A50758-6892858604165181440%29 : [image: image] https://user-images.githubusercontent.com/5757396/211570402-80813678-06d1-464f-a6cf-a70212b39944.png 2.
Based on the version which ended up in the spec https://pubs.opengroup.org/architecture/archimate32-doc/#_Toc112155048 (which is slighly different): [image: image] https://user-images.githubusercontent.com/5757396/211571830-d40c4aec-3f93-4469-84a4-0c0f8924b4c6.png
@Phillipus https://github.com/Phillipus Which one do you prefer ?
— Reply to this email directly, view it on GitHub https://github.com/archimatetool/archi/issues/893, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACSM7D34P3BADVHVWH6GCJTWRVUA3ANCNFSM6AAAAAATW2ZBP4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>
@Phillipus Just noticed (but too late) that I pushed to master
instead of a feature branch :-(
That just shows how confident you are in your change. :-)
I pushed a branch wp-figure
and put master
back to how it was with a force push. You'll need to pull and reset.
I got a mix of tabs and spaces in AbstractTextControlContainerFigure.java
so hard to see what changed there. Maybe your Eclipse is set to use tabs instead of spaces.
I got a mix of tabs and spaces in AbstractTextControlContainerFigure.java so hard to see what changed there. Maybe your Eclipse is set to use tabs instead of spaces.
Maybe, I'll have a look (trying to get everything working again now that target has changed...)
I can reformat and force push the branch if you'd prefer.
Don't worry about the spaces thing, it had tabs in anywyay. I force pushed wp-figure
again anyway.
I tested this and the change in #895 and it's all good by me. Let's commit this and get Archi 5 out!
Let's commit this and get Archi 5 out!
waiiiiiiittttttt, I still have to fix the meaning figure
I still have to fix the meaning figure
What do you, er, mean? Oh yeah I forgot about that one, needs an extra bubble...
I'm tuning the workpackage small icon (the one used in the box notation) and came up with two variants:
1) Based on the very first proposal I made on LinkedIn:![image](https://user-images.githubusercontent.com/5757396/211570402-80813678-06d1-464f-a6cf-a70212b39944.png)
2) Based on the version which ended up in the spec (which is slighly different):![image](https://user-images.githubusercontent.com/5757396/211571830-d40c4aec-3f93-4469-84a4-0c0f8924b4c6.png)
@Phillipus Which one do you prefer ?