search

archimatetool / archi

Archi: ArchiMate Modelling Tool
https://www.archimatetool.com
MIT License
914 stars 267 forks source link

[DRAFT] Added letter based cues to distinguish between layers of the framework. #908

Closed pvginkel closed 1 year ago

pvginkel commented 1 year ago

Visually based on https://pubs.opengroup.org/architecture/archimate3-doc/chap12.html#_Toc437870133. Closes #907.

This is a draft still. Requesting review from @Phillipus.

The letters are there. I do still need to add a checkbox in te preferences dialog and disable this by default.

Phillipus commented 1 year ago
  1. Do other users want this?
  2. The letter is placed outside of non-rectangular figures. Might need active placement.
  3. The letter is obscured if the element text alignment is on the left. Again, might need active placement.
  4. The letter doesn't need to be in a TextFlow component as it is non-editable, it can be drawn as a Paint listener
  5. What about font colour?
  6. Do current Unit Tests pass?
  7. Does it require Unit Tests?
  8. If implemented, it should be as an option for each graphical instance.
  9. What documentation would need to be updated?
  10. more.....

Before coding a PR these issues need to be addressed first, particularly (1) .

pvginkel commented 1 year ago

Thank you for having a look so quickly. I'm not sure on quite a few of these questions. I am however motivated to get a change like this through. We really like the tool at our company but we do have accessibility requirements I can't ignore.

I have no previous experience with the Ellipse framework so I'm happy for the input. Would you be working to help me get this PR to a good enough state? If so, I'll take some time to solve the issues I can, and have a good look at your questions. I'd also like a pointer on your first question, because I don't know how I would go about answering it.

Phillipus commented 1 year ago

I am however motivated to get a change like this through. We really like the tool at our company but we do have accessibility requirements I can't ignore.

There are several thousand other Archi users and plenty of outstanding features that take priority over this that I can't ignore. Whether your company uses Archi or not because of this is not my concern.

pvginkel commented 1 year ago

Thank you for having a look though. I'll use your input on how we can design our viewpoints.