archimatetool / archi

Archi: ArchiMate Modelling Tool
https://www.archimatetool.com
MIT License
914 stars 267 forks source link

Meaning Icon #912

Closed jbsarrodie closed 1 year ago

jbsarrodie commented 1 year ago

Let's open this issue to discuss the meaning icon

Phillipus commented 1 year ago

I can discuss the meaning of life...

jbsarrodie commented 1 year ago

I can discuss the meaning of life...

;-)

I've just pushed a proposal for an enhanced Meaning icon. It is based on bezier curves. I've configured it so that points and control points are on a 12x7 grid (easier to manage). You can do simulations using this online tool and setting this background image.

Here's what I used while coding: image

Phillipus commented 1 year ago

Beautiful. :-)

But you missed an important change:

Remove this comment:

// The following is the most awful code to draw a cloud...

and replace with something appropriate. ;-)

Phillipus commented 1 year ago

The path code is duplicated could it be used just once?

jbsarrodie commented 1 year ago

The path code is duplicated could it be used just once?

If everything else is ok, then, yes, I can refactor it (and add a helper function to simplify the calls to .cubicTo())

Phillipus commented 1 year ago

If everything else is ok

Superb work! 👏

I can refactor it

Please do. Do a force push if you can. :-)

jbsarrodie commented 1 year ago

Please do. Do a force push if you can. :-)

Done ;-)

Phillipus commented 1 year ago

Merged to master, thank-you. :-)