archimatetool / archi

Archi: ArchiMate Modelling Tool
https://www.archimatetool.com
MIT License
914 stars 267 forks source link

Folder Label Expressions not redered in HTML report #924

Open JelleS-EA opened 1 year ago

JelleS-EA commented 1 year ago

Version of Archi

5.0.0

Archi Plug-ins

coArchi 0.8.7 Excel for Archi 1.0.0. jArchi 1.3.1 Lightbox for Archi 1.2.0

Operating System

Windows

Expected Behaviour

Show view names in HTLM report as per folder label and as shown in archi models panel.

Actual Behaviour

Shows only view names in HTLM report

Steps to Reproduce the Behaviour

  1. Set Views folder (from models panel) Label Expression to: ${if:${viewpoint}:${name} - ${viewpoint} view:${name}}
  2. Observe canvas showing names only in any of the views folders
  3. Observe ArchimateViews showing names - [selected viewpoint] view
  4. Create HTML Report
  5. Observe the Model Tree views naming
  6. Observe the namins of diagram shortcuts in canvas views
Phillipus commented 1 year ago

At the moment, the HTML report does not consider label expressions in its implementation. See also https://github.com/archimatetool/archi/issues/864

Phillipus commented 1 year ago

I looked into this. The code for rendering folder label expressions pertains to rendering the folder's child objects in the context of the Models Tree. The HTML report doesn't know about that context and only knows about the object's name. I tried applying the label expression to the object's name before rendering the report but that changed the name everywhere, including in views. This will need a deeper investigation.

JelleS-EA commented 1 year ago

@Phillipus, I think what you describe may be the usecase I was considering. Using the name element to reflect the context of a diagram and the viewpoint to highlight/address a concern? I could re-use (duplicate) the same diagram (and therefore its name) and set a new Viewpoint. I can decide to leave the faded elements in or not and add what is appropriate to address that concern?