Closed zaptrem closed 1 year ago
Can you put the ID3 extension in a WavID3Dataset
or something named like that, and the argument for the optimized random crop you can simply call it random_crop
Can you put the ID3 extension in a
WavID3Dataset
or something named like that, and the argument for the optimized random crop you can simply call itrandom_crop
I renamed optimized_random_crop_size
to random_crop_size
, but the ID3 extension will be difficult to move. I moved it there in the first place to handle the case where torchaudio
is able to read a file but TinyTag
isn't. Moving it back outside would require a complicated dance of calling back and fourth to and from the superclass's load functions and lots of catch logic that would complicate MetaDataset
(but is a one-liner when in WAVDataset
).
This PR fixes a few issues I ran into while setting things up with ZQEvans' dataset.
The dataloader could cause a crash in certain cases...
optimized_random_crop
with certain sample ratesoptimized_random_crop
disabled(?)Additionally, while
pandas
andyt_dlp
are required to import the library, they previously weren't listed in dependencies.