I would like to suggest a little improvement to the trainerdata.txt file and the handling of it done by the mod. Imagine a scenario where the genned Pokémon comes from an older game like Emerald and the OT/TID/SID is the same one as the other Pokémon that were already genned in a USUM environment. Before the addition of trainerdata.txt, the mod handled different IDs. Those were put in the code under a section in PKSMAutoLegality.cs, editing the default one and adding an inefficient but effective series of "if" and "else" that changed the trainer data basing on the game that Pokémon origin was given to by the mod.
The thing I wish will be implemented is to have the regular behaviour for the people that have a trainerdata.txt with only one ID (maybe called "Default ID") [pretty much the same function as now] and let the mod handle multiple IDs (with every one of them with a game identifier like "UM" for UM or "E" for Emerald) if those were put in the trainerdata.txt . Whenever the Pokémon that is genned comes from another game it will have instantly the "secondary ID" coinciding with that specified game.
And just to bring things further, enable an option (maybe this will be better as an addon) for a "Manual mode" to have a pop-up dialog box that let's you choose the origin game if the Pokémon can have an origin from different games, instead of the usual "Automated" way. I know that this idea can be against the original mindset of the mod cause it will imply an "user" clicking, instead of processing all the data automatically, but as an addon it wouldn't cause harm to anyone who just wants the mod as it is.
That's all folks!
P.S. Sorry for my bad English :(
I would like to suggest a little improvement to the trainerdata.txt file and the handling of it done by the mod. Imagine a scenario where the genned Pokémon comes from an older game like Emerald and the OT/TID/SID is the same one as the other Pokémon that were already genned in a USUM environment. Before the addition of trainerdata.txt, the mod handled different IDs. Those were put in the code under a section in PKSMAutoLegality.cs, editing the default one and adding an inefficient but effective series of "if" and "else" that changed the trainer data basing on the game that Pokémon origin was given to by the mod.
The thing I wish will be implemented is to have the regular behaviour for the people that have a trainerdata.txt with only one ID (maybe called "Default ID") [pretty much the same function as now] and let the mod handle multiple IDs (with every one of them with a game identifier like "UM" for UM or "E" for Emerald) if those were put in the trainerdata.txt . Whenever the Pokémon that is genned comes from another game it will have instantly the "secondary ID" coinciding with that specified game.
And just to bring things further, enable an option (maybe this will be better as an addon) for a "Manual mode" to have a pop-up dialog box that let's you choose the origin game if the Pokémon can have an origin from different games, instead of the usual "Automated" way. I know that this idea can be against the original mindset of the mod cause it will imply an "user" clicking, instead of processing all the data automatically, but as an addon it wouldn't cause harm to anyone who just wants the mod as it is.
That's all folks! P.S. Sorry for my bad English :(