architect / arc.codes

The Architect web site! 🌩
https://arc.codes
Apache License 2.0
315 stars 101 forks source link

Clarify that direct deploys require a glob-compatible path parameter #297

Open filmaj opened 3 years ago

filmaj commented 3 years ago

Describe the issue The current CLI reference for deploy makes no mention of the need to pass a path-like parameter to the command. Kind of integral to direct/dirty deploys!

Steps to reproduce See https://arc.codes/reference/cli/deploy

Expected behavior We should make that clear.

Additional context Someone was having trouble with that command on Slack and this issue was a point of confusion! See https://architecture-as-text.slack.com/archives/C6BGT0D08/p1607807121269300

tbeseda commented 3 years ago

Looking at some open issues. This is an easy change that is still relevant IMO But I'm wondering if we should remove "dirty" from the docs in favor of "direct". From what I can tell, "dirty" is legacy and just supported in architect/deploy as an alias for "direct" right?

filmaj commented 3 years ago

I believe direct is preferred over dirty, though it has never been discussed.