architect / functions

AWS Lambda Node runtime helpers for Architect apps
https://arc.codes
163 stars 38 forks source link

Deep require `aws-sdk` deps for a potentially large cold start perf boost #520

Closed ryanblock closed 2 years ago

ryanblock commented 2 years ago

Retire aws-sdk-mock (84.8MB) for ~15 lines of code

Thank you for helping out! ✨

We really appreciate your commitment to improving Architect

To maintain a high standard of quality in our releases, before merging every pull request we ask that you've completed the following:

Please also be sure to completed the CLA (if you haven't already).

Learn more about contributing to Architect here.

Thanks again!

ryanblock commented 2 years ago

This is rad. I'm seeing consistent ~150ms requires for all the core services Arc Functions uses. This is a gigantic improvement compared to 400-900ms just loading all of aws-sdk in Lambda.

If we land this PR, this means the coldstart hit of Arc Functions hit will always be within a band of ~30-180ms.