architect / plugin-remix

Architect plugin for Remix.
https://www.npmjs.com/package/@architect/plugin-remix
Apache License 2.0
13 stars 1 forks source link

Failed to require remix internals #5

Open misantronic opened 2 years ago

misantronic commented 2 years ago

I'm using remix@1.6.5 The plugin tries to require some remix-internals in several places, e.g util.js:6, index.js:11 and 12 and watcher.js:1

Problem is, that it fails to f.e. require('@remix-run/dev/config'). The correct path would be: require('@remix-run/dev/dist/config') as the @remix-run/dev lib is pointing to dist/index and is not referring to the config.js-file.

wperches commented 1 year ago

This issue is still ongoing. I booted a remix grunge stack, but am unable to hydrate the project.

input-> npx arc hydrate

output->

hydrate failed! Plugin error:

wperches commented 1 year ago

required change at plugin-remix/src/util.js line 6

const remixConfig = require('@remix-run/dev/dist/config')

tbeseda commented 1 year ago

I can take a look at this today. I thought it might break eventually

// ! Use of Remix internals. API not guaranteed:

Thanks for the example @wperches and @misantronic

edit:

[...] I booted a remix grunge stack, but am unable to hydrate the project.

Oh I just realized you mentioned the Grunge Stack. That's a Remix template, this plugin is not that. This plugin is a wholly different approach to deploying Remix apps with Architect. I don't imagine that they are compatible. they don't aim to be.

That said, if there's still usage on this plugin, I think I can update it to work with new Remix as I see they are on 2.1

wperches commented 1 year ago

Thanks for the speedy follow ups @tbeseda.

The grunge stack boots up with architect to deploy directly to aws and I was following a guide that was using the plugin. @remix-run/architect instead of @architect/plugin-remix. 👍

Either way, after walking through the troubleshooting steps the directory adjustments will work for 2/3 of the initial ticket, but there was another require() for a build folder that I couldn't find inside dist (maybe in 2.1).

In the generated package.json my dependency tree for remix-run/dev:

+-- @architect/plugin-remix@0.2.3 | -- @remix-run/dev@1.19.3 -- @remix-run/dev@2.1.0