search

architecture-building-systems / ASF_Simulation

Numerical Simulation of the ASF to determine its energy saving potential and optimal configurations
4 stars 3 forks source link

Setting the date for hourly results #11

Open pjayathissa opened 7 years ago

pjayathissa commented 7 years ago

It is not clear how the SimulationPeriod compares with the PV_Result FileName

    SimulationPeriod = {
    'FromMonth': 1, #7, #1,
    'ToMonth': 1,#7, #1,
    'FromDay': 8, #6, #8,
    'ToDay': 8, #8,
    'FromHour': 5,#5
    'ToHour': 20}#20
MauroLuzzatto commented 7 years ago

That's an easy one. There is not connection between the name and the simulation period, I just used names in a way to rember what day respectively simulationperiod I analysed. Hope that helps.

pjayathissa commented 7 years ago

However when I change the month numbers, or the FileName I get an error saying that the date is out of range

File "/Users/jayathip/Documents/100_SuAt/190_Software/ASF_Simulation/ASF_Simulation/Simulation_Tool/New_SimulationEnvironment_Ladybug/SimulationClassHourly.py", line 338, in PrepareRadiationData
    self.BuildingRadiationHOY[HOY] = self.HourlyRadiation[monthi][day][hour] #W
KeyError: 2
MauroLuzzatto commented 7 years ago

So, for this particular file of a summer day, I simulated only the hours from 6:00 until 20:00 at July the 6th. Therefore python won't find the data for other simulation periods for this particular file (as you tried with 2 (not sure if you chose the hour, month or day, but it is for sure no data available...). Did this make it clear?

You might want to recalculate the radiation and PV_files, since I there was a bug, which I then fixed (with the hour shift)