architecture-building-systems / CityEnergyAnalyst

The City Energy Analyst (CEA)
https://www.cityenergyanalyst.com/
MIT License
196 stars 65 forks source link

Qwwf does not match mcpwwf*(Tsupwwf-Tretwwf) in Demand files #1337

Closed roglen closed 6 years ago

roglen commented 6 years ago

Energy Balance in Demand files of the open case for wwf do not add up.

The way I understand it, per definition, Qwwf = mcpwwf * (Tsupwwf-Tretwwf).

This does not apply in the open case for DH, checked for B02 and B03.

This causes a wrong output of heating demands and distorts results in thermal_network_matrix.py

B03_error.xlsx

roglen commented 6 years ago

@shanshanhsieh @gabriel-happle not really sure who this applies to, issue #66 is not directly related to this as far as I can tell.

gabriel-happle commented 6 years ago

I think @shanshanhsieh is very busy. I'll take a look at the code.

gabriel-happle commented 6 years ago

The reason for this is that mcpwwf is calculated between Tww_tank - Tww_re in calc_Qwwf() in hotwater_loads.py. @shanshanhsieh is taking over from here.

The issue is not critical for the Singapore case, as there is no district heating network planned.

jimenofonseca commented 6 years ago

@roglen I included a fix in the branch i1289. could you tell me if this fixes the issue? you have to rerun the demand_main.py

roglen commented 6 years ago

@JIMENOFONSECA looks good now! There are still some small deviations, but now they are around 0.1% which I think is reasonable.

jimenofonseca commented 6 years ago

Yep, it is a rounding error I believe.

Jimeno


From: Lennart Rogenhofer [notifications@github.com] Sent: Wednesday, May 23, 2018 4:52 PM To: architecture-building-systems/CityEnergyAnalyst Cc: Jimeno Fonseca; Mention Subject: Re: [architecture-building-systems/CityEnergyAnalyst] Qwwf does not match mcpwwf*(Tsupwwf-Tretwwf) in Demand files (#1337)

@JIMENOFONSECAhttps://github.com/JIMENOFONSECA looks good now! There are still some small deviations, but now they are around 0.1% which I think is reasonable.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/architecture-building-systems/CityEnergyAnalyst/issues/1337#issuecomment-391271761, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AIjrgoZ_9FY90mLnVP7JY122al89P35Iks5t1SNLgaJpZM4UCTFr.