architecture-building-systems / CityEnergyAnalyst

The City Energy Analyst (CEA)
https://www.cityenergyanalyst.com/
MIT License
196 stars 66 forks source link

Add location to plotting interface #1349

Closed gabriel-happle closed 6 years ago

gabriel-happle commented 6 years ago

The comfort plots for individual buildings uses the input locator and region to check if there is a winter = has_heating_season and/or a summer = has_cooling_season in the region specific database to calculate different comfort conditions.

Plots will work fine if the Region is not chosen correctly, but numbers in tables don't make much sense. A simple workaround is to change the config file Region manually.

not sure which milestone to use. @daren-thomas is it easy to add the region to the plotting interface in ArcGIS? basically I was expecting that when you change the region for the demand calculation it will stick with the config file for the rest of the scripts. I didn't know that the arcgis resets the config file all the time.

daren-thomas commented 6 years ago

arcgis doesn't reset the config file at all. it just overrides the values for the run. so setting the region in the config file will keep it there.

daren-thomas commented 6 years ago

@gabriel-happle I'm interpreting this issue as adding a drop-down box for selecting the region used for the plots interface in ArcGIS (as opposed to printing it out on the plots generated). yes. this is quite easy to do. I'm working on a pull request right now.

daren-thomas commented 6 years ago

bundling this up with #1321, which already deals with changes to the plots interface.

gabriel-happle commented 6 years ago

thank you @daren-thomas