architecture-building-systems / CityEnergyAnalyst

The City Energy Analyst (CEA)
https://www.cityenergyanalyst.com/
MIT License
196 stars 62 forks source link

DH_hs_MWhyr, DC_hs_MWhyr and district energy supply plots are misleading #1834

Closed martin-mosteiro closed 5 years ago

martin-mosteiro commented 5 years ago

I think these variables and plots present misleading information.

See line 308 in thermal_loads.py - here the electricity demand for producing the district heating used in the district is calculated, not the amount of district heating supplied (i.e., tsd['DH_hs'] = tsd['Qhs_sys'] / efficiency_average_year, where the efficiency_average_year is a COP). However, since the variable is labeled "DC" or "DH" it would seem to be representing the amount of heating/cooling extracted from the network, not the electricity used to produce it.

Furthermore, the district energy supply plots show a stacked bar chart with the following values: "District electricity consumption", "District cooling for space cooling demand", "District heating for space heating demand" and "District heating for hotwater demand" (also, note the typo while we're at it). However the y axis is labeled a very generic "Energy demand [MWh/yr]", so I think it gives the wrong impression.

I think these variables should be renamed and the plots be redone in a more intuitive way.

jimenofonseca commented 5 years ago

@martin-mosteiro could you describe the steps you made. Maybe I can reproduce and see which plots you mean? A picture of the plots you are referring to will also be useful. I get lost in the variety :-)

martin-mosteiro commented 5 years ago

@FionaCollins could you maybe provide one of the graphs or data sets that we discussed the other day? @JIMENOFONSECA basically DC_sys in the outputs is given as Qcs_sys/COP. So if the cooling demand is, say, 300 MWh/yr and the system COP is 3, then DC_sys is 100 MWh/yr. But this would then be 100 MWh/yr of electricity, not 100 MWh/yr of cooling, hence why I think the naming is misleading.

FionaCollins commented 5 years ago

The columns you are talking about are highlighted in the file attached here: The COP of the cooling and heating systems (defined in the LCA databases) was 2.85

Total_demand.xlsx

daren-thomas commented 5 years ago

@martin-mosteiro, @FionaCollins: I think what @JIMENOFONSECA was asking for is the list of plots affected?

I'm changing this from "Should have" to "Must have", since I believe credibility of outputs is our main currency. We're working on a more up-to-date glossary with @Jack-Hawthorne. This takes time, but will require input from everyone to get the provenance of each output variable explicitly described.

martin-mosteiro commented 5 years ago

@FionaCollins do you have the plots we generated through CEA that showed the district energy balance? I think those make the issue quite clear. Thanks!

FionaCollins commented 5 years ago

energy supply for district: image

energy demand for district: image

jimenofonseca commented 5 years ago

@martin-mosteiro @FionaCollins would you mind explaining what the issue is and how it reflects in the plots? Advice on what to modify would be welcome.

martin-mosteiro commented 5 years ago

@JIMENOFONSECA The top plot posted by Fiona says "District heating for space heating demand". This is itself not a very clear statement.

daren-thomas commented 5 years ago

We decided it's an error. @JIMENOFONSECA will look into this.