architecture-building-systems / CityEnergyAnalyst

The City Energy Analyst (CEA)
https://www.cityenergyanalyst.com/
MIT License
197 stars 66 forks source link

Solar Potential Calculation on HQ #2645

Closed matthiassulzer closed 4 years ago

matthiassulzer commented 4 years ago

Describe the bug Rey, everything works fine…. Exept the calculation of the solar potential: City Energy Analyst version 2.32.0 Running cea photovoltaic with the following parameters:

gathering properties of PV panel filtering low potential sensor points done calculating optimal tile angle and separation done generating groups of sensor points done Could you give me a hint, what is wrong?

Best,

Matthias

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behaviour A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Hardware (please complete the following information):

daren-thomas commented 4 years ago

Maybe due to solar:annual-radiation-threshold = 800.0 some of the buildings are being filtered out. @matthiassulzer would you mind trying to re-run this with annual-radiation-threshold = 400.0? Does that work?

matthiassulzer commented 4 years ago

Hi Daren

Thanks for the hint… unfortunately the error still occurs: Job Output for 1 - photovoltaic City Energy Analyst version 2.32.0 Running cea photovoltaic with the following parameters:

filtering low potential sensor points done calculating optimal tile angle and separation done generating groups of sensor points done calculating solar properties done Best,

Matthias

Von: Daren Thomas notifications@github.com Gesendet: Donnerstag, 19. März 2020 12:01 An: architecture-building-systems/CityEnergyAnalyst CityEnergyAnalyst@noreply.github.com Cc: Sulzer, Matthias Matthias.Sulzer@empa.ch; Mention mention@noreply.github.com Betreff: Re: [architecture-building-systems/CityEnergyAnalyst] Solar Potential Calculation on HQ (#2645)

Maybe due to solar:annual-radiation-threshold = 800.0 some of the buildings are being filtered out. @matthiassulzerhttps://github.com/matthiassulzer would you mind trying to re-run this with annual-radiation-threshold = 400.0? Does that work?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/architecture-building-systems/CityEnergyAnalyst/issues/2645#issuecomment-601117631, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AM6FZI2FXHKTGCLG6JTUGGLRIH3QDANCNFSM4LNJFODA.

reyery commented 4 years ago

Hmm. I think there is something different with the radiation output files.

ValueError: operands could not be broadcast together with shapes (8784,) (8784,) (8784,) () (8760,) (8760,) () () ()

The magical number 8760 is actually the number of hours in a year.

So the radiation file for a building is supposed to have 8760 rows of radiation data.

rqad

But the radiation files that were created have 8784 rows = 24 hours difference = 1 day. And since the weather file is based on 2016 (leap year), a leap year day was probably included when calculating radiation.

ras

I'm still investigating why the radiation script is doing this. Because the weather file provided has exactly 8760 records even though from 2016, so radiation could be adding that extra row somewhere.

matthiassulzer commented 4 years ago

Many thanks for your help. Hopefully you find the mistake...

Freundliche Grüsse

Matthias Sulzer

Am 20.03.2020 um 12:27 schrieb Reynold Mok notifications@github.com:



Hmm. I think there is something different with the radiation output files.

ValueError: operands could not be broadcast together with shapes (8784,) (8784,) (8784,) () (8760,) (8760,) () () ()

The magical number 8760 is actually the number of hours in a year.

So the radiation file for a building is supposed to have 8760 rows of radiation data.

[rqad]https://user-images.githubusercontent.com/34395415/77156064-8f216780-6ad9-11ea-8e31-29b578f3482f.PNG

But the radiation files that were created have 8784 rows = 24 hours difference = 1 day. And since the weather file is based on 2016 (leap year), a leap year day was probably included when calculating radiation.

[ras]https://user-images.githubusercontent.com/34395415/77156006-7022d580-6ad9-11ea-8ae0-811282f6a069.PNG

I'm still investigating why the radiation script is doing this. Because the weather file provided has exactly 8760 records even though from 2016, so radiation could be adding that extra row somewhere.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/architecture-building-systems/CityEnergyAnalyst/issues/2645#issuecomment-601652502, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AM6FZI3RV6UFGPBGA5LSMG3RINHJLANCNFSM4LNJFODA.

reyery commented 4 years ago

I think what is happening here is that DAYSIM (epw2wea) is including the leap year day when converting the .epw file that we provide to the .wea file that it uses for calculation.

So I think we might have to handle this (leap year) on our end (unless there is a parameter/property that we can include in the header file or command to do this, but the DAYSIM website is down now so I'm not sure), by removing extra rows if needed by making sure it has the same number of rows as the provided weather file since we are calculating solar potentials against that.

matthiassulzer commented 4 years ago

Perfect. I am waiting for an update on github. Please advise me, when I can request a pull….

Von: Reynold Mok notifications@github.com Gesendet: Freitag, 20. März 2020 13:03 An: architecture-building-systems/CityEnergyAnalyst CityEnergyAnalyst@noreply.github.com Cc: Sulzer, Matthias Matthias.Sulzer@empa.ch; Mention mention@noreply.github.com Betreff: Re: [architecture-building-systems/CityEnergyAnalyst] Solar Potential Calculation on HQ (#2645)

I think what is happening here is that DAYSIM (epw2wea) is including the leap year day when converting the .epw file that we provide to the .wea file that it uses for calculation.

So I think we might have to handle this (leap year) on our end (unless there is a parameter/property that we can include in the header file or command to do this, but the DAYSIM website is down now so I'm not sure), by removing extra rows if needed by making sure it has the same number of rows as the provided weather file since we are calculating solar potentials against that.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/architecture-building-systems/CityEnergyAnalyst/issues/2645#issuecomment-601665336, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AM6FZIY2ZQU4MRHRYFJNVKLRINLNZANCNFSM4LNJFODA.

reyery commented 4 years ago

Ah of course! The data for the leap day is actually in the weather file! That is why DAYSIM has the information for the extra rows, since it is reading straight from the file, albeit the converted one. There is nothing wrong with what DAYSIM was doing but how we are reading the weather file on our end.

image

For some reason our epwreader is only including the HOURS_IN_YEAR number of rows in L30. Any ideas why it was done like this? @JIMENOFONSECA. Maybe to keep the number of rows the same? But would that affect any other calculation if it were different?

In the case of a leap year data, for 31 December is left out.

https://github.com/architecture-building-systems/CityEnergyAnalyst/blob/a7816e60c10558ecd59208bbe0efb095c945bc1f/cea/utilities/epwreader.py#L21-L38

jimenofonseca commented 4 years ago

I think we need to leave out the 29th of February (which is the difference with the leap year). The best is that the epw reader do this check, if 29th of february exist, then erase the day. Confirm that the file has 8760 entries.

On 21 Mar 2020, 21:12 +0800, Reynold Mok notifications@github.com, wrote:

Ah of course! The data for the leap day is actually in the weather file! That is why DAYSIM has the information for the extra rows, since it is reading straight from the file, albeit the converted one. There is nothing wrong with what DAYSIM was doing but how we are reading the weather file on our end.

[image]https://user-images.githubusercontent.com/34395415/77226931-feb95480-6bb6-11ea-9a7d-aaa93d98a7cd.png

For some reason our epwreader is only including the HOURS_IN_YEAR number of rows in L30. Any ideas why it was done like this? @JIMENOFONSECAhttps://github.com/JIMENOFONSECA. Maybe to keep the number of rows the same? But would that affect any other calculation if it were different?

In the case of a leap year data, for 31 December is left out.

https://github.com/architecture-building-systems/CityEnergyAnalyst/blob/a7816e60c10558ecd59208bbe0efb095c945bc1f/cea/utilities/epwreader.py#L21-L38

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/architecture-building-systems/CityEnergyAnalyst/issues/2645#issuecomment-602041874, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACEOXAR2QFIUZJABPUM245TRIS4KRANCNFSM4LNJFODA.

reyery commented 4 years ago

@JIMENOFONSECA I have removed the leap day in epwreader but it still gives the same error since DAYSIM would still include the leap day. I think we would still have to edit the radiation output results if you really want to maintain the 8760 rows everywhere.

jimenofonseca commented 4 years ago

Yes, let’s do that.

Jimeno


Jimeno A. Fonseca Dr. Sc. ETH Zurich

Senior Researcher Singapore ETH-Centre (SEC)https://sec.ethz.ch/

Project Coordinator Multi-Scale Energy Systems (MuSES)https://fcl.ethz.ch/research/high-density-cities/multi-scale-energy-systems.html

Product Owner & Developer City Energy Analyst (CEA)https://cityenergyanalyst.com/

Principal Investigator Cooling Singapore (CS1.5)https://www.coolingsingapore.sg/ Future Resilience Systems (FRS)https://frs.ethz.ch/research/cyber-physical-systems/digital-twin-enabled-system-resilience.html

On 24 Mar 2020, 16:26 +0800, Reynold Mok notifications@github.com, wrote:

@JIMENOFONSECAhttps://github.com/JIMENOFONSECA I have removed the leap day in epwreader but it still gives the same error since DAYSIM would still include the leap day. I think we would still have to edit the radiation output results if you really want to maintain the 8760 rows everywhere.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/architecture-building-systems/CityEnergyAnalyst/issues/2645#issuecomment-603097766, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACEOXAWW23ZHYOYX65GHAALRJBVATANCNFSM4LNJFODA.

matthiassulzer commented 4 years ago

Hi Rey

Please let me know, if you fixed the solar problem. Thanks.

And could you advise me, why no jobs are getting executed, after I pulled all new changes from GitHub? [cid:image001.png@01D602AC.5830EC40]

Best,

Matthias

Von: Reynold Mok notifications@github.com Gesendet: Freitag, 20. März 2020 13:03 An: architecture-building-systems/CityEnergyAnalyst CityEnergyAnalyst@noreply.github.com Cc: Sulzer, Matthias Matthias.Sulzer@empa.ch; Mention mention@noreply.github.com Betreff: Re: [architecture-building-systems/CityEnergyAnalyst] Solar Potential Calculation on HQ (#2645)

I think what is happening here is that DAYSIM (epw2wea) is including the leap year day when converting the .epw file that we provide to the .wea file that it uses for calculation.

So I think we might have to handle this (leap year) on our end (unless there is a parameter/property that we can include in the header file or command to do this, but the DAYSIM website is down now so I'm not sure), by removing extra rows if needed by making sure it has the same number of rows as the provided weather file since we are calculating solar potentials against that.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/architecture-building-systems/CityEnergyAnalyst/issues/2645#issuecomment-601665336, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AM6FZIY2ZQU4MRHRYFJNVKLRINLNZANCNFSM4LNJFODA.

reyery commented 4 years ago

@matthiassulzer you would need to overwrite the interface with the latest one which was not included in the current release. There was a change in master that has made the one that you have installed not able to send jobs to CEA.

You could download the pre-release version here and extract to overwrite the one that you have.

image

matthiassulzer commented 4 years ago

Perfect! It works agin. Many thanks ☺

Von: Reynold Mok notifications@github.com Gesendet: Mittwoch, 25. März 2020 13:58 An: architecture-building-systems/CityEnergyAnalyst CityEnergyAnalyst@noreply.github.com Cc: Sulzer, Matthias Matthias.Sulzer@empa.ch; Mention mention@noreply.github.com Betreff: Re: [architecture-building-systems/CityEnergyAnalyst] Solar Potential Calculation on HQ (#2645)

@matthiassulzerhttps://github.com/matthiassulzer you would need to overwrite the interface with the latest one which was not included in the current release. There was a change in master that has made the one that you have installed not able to send jobs to CEA.

You could download the pre-release version herehttps://github.com/architecture-building-systems/CityEnergyAnalyst-GUI/releases/download/v3.0.2/win-unpacked.7z and extract to overwrite the one that you have.

[image]https://user-images.githubusercontent.com/34395415/77538743-31c35700-6edb-11ea-948c-71337d5d0a0a.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/architecture-building-systems/CityEnergyAnalyst/issues/2645#issuecomment-603824125, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AM6FZI6PGGSJIS2CSUGAAHDRJH5XHANCNFSM4LNJFODA.

matthiassulzer commented 4 years ago

Hi Rey

I hope you progress with Daysim. I just recognized a minor tipper: relative Demand and Supply should be W/m2 instead of kW/m2.

Best,

M [cid:image002.jpg@01D6050B.E5908080]

Von: Reynold Mok notifications@github.com Gesendet: Freitag, 20. März 2020 13:03 An: architecture-building-systems/CityEnergyAnalyst CityEnergyAnalyst@noreply.github.com Cc: Sulzer, Matthias Matthias.Sulzer@empa.ch; Mention mention@noreply.github.com Betreff: Re: [architecture-building-systems/CityEnergyAnalyst] Solar Potential Calculation on HQ (#2645)

I think what is happening here is that DAYSIM (epw2wea) is including the leap year day when converting the .epw file that we provide to the .wea file that it uses for calculation.

So I think we might have to handle this (leap year) on our end (unless there is a parameter/property that we can include in the header file or command to do this, but the DAYSIM website is down now so I'm not sure), by removing extra rows if needed by making sure it has the same number of rows as the provided weather file since we are calculating solar potentials against that.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/architecture-building-systems/CityEnergyAnalyst/issues/2645#issuecomment-601665336, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AM6FZIY2ZQU4MRHRYFJNVKLRINLNZANCNFSM4LNJFODA.

reyery commented 4 years ago

@matthiassulzer I have already come up with a fix and an waiting for testing to pass before merging it to master.

matthiassulzer commented 4 years ago

Ufff. Many thanks. I am looking forward to it.

Von: Reynold Mok notifications@github.com Gesendet: Mittwoch, 1. April 2020 11:39 An: architecture-building-systems/CityEnergyAnalyst CityEnergyAnalyst@noreply.github.com Cc: Sulzer, Matthias Matthias.Sulzer@empa.ch; Mention mention@noreply.github.com Betreff: Re: [architecture-building-systems/CityEnergyAnalyst] Solar Potential Calculation on HQ (#2645)

@matthiassulzerhttps://github.com/matthiassulzer I have already come up with a fix and an waiting for testing to pass before merging it to master.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/architecture-building-systems/CityEnergyAnalyst/issues/2645#issuecomment-607145962, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AM6FZI3VC4UD3DZZLRC4MJLRKMDUTANCNFSM4LNJFODA.

reyery commented 4 years ago

I just recognized a minor tipper: relative Demand and Supply should be W/m2 instead of kW/m2.

@matthiassulzer, I am trying to find this variable but I am not too sure where it is from. May I know which one you are referring to?

matthiassulzer commented 4 years ago

Hi Rey

In the dash board: if I am choosing add plot, energy demand, peak demand, the graph shows in the section Relative (kW/m2). In my mind it should be W/m2. Clear?

[cid:image001.jpg@01D608DE.8C504100]

Von: Reynold Mok notifications@github.com Gesendet: Donnerstag, 2. April 2020 09:16 An: architecture-building-systems/CityEnergyAnalyst CityEnergyAnalyst@noreply.github.com Cc: Sulzer, Matthias Matthias.Sulzer@empa.ch; Mention mention@noreply.github.com Betreff: Re: [architecture-building-systems/CityEnergyAnalyst] Solar Potential Calculation on HQ (#2645)

I just recognized a minor tipper: relative Demand and Supply should be W/m2 instead of kW/m2.

@matthiassulzerhttps://github.com/matthiassulzer, I am trying to find this variable but I am not too sure where it is from. May I know which one you are referring to?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/architecture-building-systems/CityEnergyAnalyst/issues/2645#issuecomment-607666097, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AM6FZI3K7VRZMXXEAL4ACV3RKQ3TDANCNFSM4LNJFODA.

matthiassulzer commented 4 years ago

Hi Rey

How does it look like? Is the bug of the daysim solved? Thanks for a quick update.

Best,

Matthias

Von: Reynold Mok notifications@github.com Gesendet: Mittwoch, 1. April 2020 11:39 An: architecture-building-systems/CityEnergyAnalyst CityEnergyAnalyst@noreply.github.com Cc: Sulzer, Matthias Matthias.Sulzer@empa.ch; Mention mention@noreply.github.com Betreff: Re: [architecture-building-systems/CityEnergyAnalyst] Solar Potential Calculation on HQ (#2645)

@matthiassulzerhttps://github.com/matthiassulzer I have already come up with a fix and an waiting for testing to pass before merging it to master.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/architecture-building-systems/CityEnergyAnalyst/issues/2645#issuecomment-607145962, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AM6FZI3VC4UD3DZZLRC4MJLRKMDUTANCNFSM4LNJFODA.

matthiassulzer commented 4 years ago

Hi Shanshan

How are you? I hope you are well in Singapore. I am just wondering, why this issue is closed. There is still an error by calculating the solar potential. Many thanks for a short feedback.

Best,

Matthias

PS. We would like to use CEA for the MBS, hence we are looking for a quick solve of the error.

Von: Shanshan Hsieh notifications@github.com Gesendet: Donnerstag, 9. April 2020 05:30 An: architecture-building-systems/CityEnergyAnalyst CityEnergyAnalyst@noreply.github.com Cc: Sulzer, Matthias Matthias.Sulzer@empa.ch; Mention mention@noreply.github.com Betreff: Re: [architecture-building-systems/CityEnergyAnalyst] Solar Potential Calculation on HQ (#2645)

Closed #2645https://github.com/architecture-building-systems/CityEnergyAnalyst/issues/2645 via #2666https://github.com/architecture-building-systems/CityEnergyAnalyst/pull/2666.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/architecture-building-systems/CityEnergyAnalyst/issues/2645#event-3216616787, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AM6FZI7NN5FRGB4Y6ZL537LRLU6MHANCNFSM4LNJFODA.

reyery commented 4 years ago

@matthiassulzer I think this issue was closed automatically after we have merged the fix to master. You could try pulling this update using the Github application and try the calculations again.

matthiassulzer commented 4 years ago

Hi Rey

Thanks for the information. I pulled on github, run the weather helper on CEA, but still get the same error, when I am running PV/solar potential:

City Energy Analyst version 3.0.2 Running cea photovoltaic-thermal with the following parameters:

Thanks,

Matthias

Von: Reynold Mok notifications@github.com Gesendet: Donnerstag, 9. April 2020 11:08 An: architecture-building-systems/CityEnergyAnalyst CityEnergyAnalyst@noreply.github.com Cc: Sulzer, Matthias Matthias.Sulzer@empa.ch; Mention mention@noreply.github.com Betreff: Re: [architecture-building-systems/CityEnergyAnalyst] Solar Potential Calculation on HQ (#2645)

@matthiassulzerhttps://github.com/matthiassulzer I think this issue was closed automatically after we have merged the fix to master. You could try pulling this update using the Github application and try the calculations again.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/architecture-building-systems/CityEnergyAnalyst/issues/2645#issuecomment-611420272, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AM6FZI6II5CP3LINLHJSY73RLWF6PANCNFSM4LNJFODA.

reyery commented 4 years ago

@matthiassulzer you would have to rerun the radiation script also since the previous radiation results would still have the leap day.

matthiassulzer commented 4 years ago

Rey, you are the best! Many thanks.

Von: Reynold Mok notifications@github.com Gesendet: Donnerstag, 9. April 2020 11:20 An: architecture-building-systems/CityEnergyAnalyst CityEnergyAnalyst@noreply.github.com Cc: Sulzer, Matthias Matthias.Sulzer@empa.ch; Mention mention@noreply.github.com Betreff: Re: [architecture-building-systems/CityEnergyAnalyst] Solar Potential Calculation on HQ (#2645)

@matthiassulzerhttps://github.com/matthiassulzer you would have to rerun the radiation script also since the previous radiation results would still have the leap day.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/architecture-building-systems/CityEnergyAnalyst/issues/2645#issuecomment-611425711, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AM6FZIZGHUVEQKAIH4FB5I3RLWHMTANCNFSM4LNJFODA.

matthiassulzer commented 4 years ago

Hi Rey I have application question: Can I only simulate one building? And how can I run the optimization for central? Do you have an idea? Thanks.

Best,

Matthias

Von: Reynold Mok notifications@github.com Gesendet: Donnerstag, 9. April 2020 11:20 An: architecture-building-systems/CityEnergyAnalyst CityEnergyAnalyst@noreply.github.com Cc: Sulzer, Matthias Matthias.Sulzer@empa.ch; Mention mention@noreply.github.com Betreff: Re: [architecture-building-systems/CityEnergyAnalyst] Solar Potential Calculation on HQ (#2645)

@matthiassulzerhttps://github.com/matthiassulzer you would have to rerun the radiation script also since the previous radiation results would still have the leap day.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/architecture-building-systems/CityEnergyAnalyst/issues/2645#issuecomment-611425711, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AM6FZIZGHUVEQKAIH4FB5I3RLWHMTANCNFSM4LNJFODA.

reyery commented 4 years ago

I'm not too sure it is possible to do optimization for one building right now. You could submit a request for this feature on GitHub if you want to do that.

matthiassulzer commented 4 years ago

Cool. Thx. I will do so.

Gruss

Matthias

Am 13.04.2020 um 10:16 schrieb Reynold Mok notifications@github.com:



I'm not too sure it is possible to do optimization for one building right now. You could submit a request for this feature on GitHub if you want to do that.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/architecture-building-systems/CityEnergyAnalyst/issues/2645#issuecomment-612801878, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AM6FZI2DOGBA7KFW6KN2AWDRMLC4DANCNFSM4LNJFODA.

matthiassulzer commented 4 years ago

Hi Rey

Everything worked out well with the HQ case…. up to now. I got the following error: City Energy Analyst version 3.1.0 Running cea radiation with the following parameters:

Best,

Matthias

Von: Sulzer, Matthias Gesendet: Donnerstag, 9. April 2020 11:30 An: 'architecture-building-systems/CityEnergyAnalyst' reply@reply.github.com; architecture-building-systems/CityEnergyAnalyst CityEnergyAnalyst@noreply.github.com Cc: Mention mention@noreply.github.com Betreff: AW: [architecture-building-systems/CityEnergyAnalyst] Solar Potential Calculation on HQ (#2645)

Rey, you are the best! Many thanks.

Von: Reynold Mok notifications@github.com<mailto:notifications@github.com> Gesendet: Donnerstag, 9. April 2020 11:20 An: architecture-building-systems/CityEnergyAnalyst CityEnergyAnalyst@noreply.github.com<mailto:CityEnergyAnalyst@noreply.github.com> Cc: Sulzer, Matthias Matthias.Sulzer@empa.ch<mailto:Matthias.Sulzer@empa.ch>; Mention mention@noreply.github.com<mailto:mention@noreply.github.com> Betreff: Re: [architecture-building-systems/CityEnergyAnalyst] Solar Potential Calculation on HQ (#2645)

@matthiassulzerhttps://github.com/matthiassulzer you would have to rerun the radiation script also since the previous radiation results would still have the leap day.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/architecture-building-systems/CityEnergyAnalyst/issues/2645#issuecomment-611425711, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AM6FZIZGHUVEQKAIH4FB5I3RLWHMTANCNFSM4LNJFODA.

matthiassulzer commented 4 years ago

… interesting: using Zürich SMA 2016 weather data, the error occurs. But using Zürich TMY 1990-2010 weather data, on error occurs.

Von: Sulzer, Matthias Gesendet: Montag, 20. April 2020 19:40 An: 'architecture-building-systems/CityEnergyAnalyst' reply@reply.github.com; 'architecture-building-systems/CityEnergyAnalyst' CityEnergyAnalyst@noreply.github.com Cc: 'Mention' mention@noreply.github.com Betreff: AW: [architecture-building-systems/CityEnergyAnalyst] Solar Potential Calculation on HQ (#2645)

Hi Rey

Everything worked out well with the HQ case…. up to now. I got the following error: City Energy Analyst version 3.1.0 Running cea radiation with the following parameters:

Best,

Matthias

Von: Sulzer, Matthias Gesendet: Donnerstag, 9. April 2020 11:30 An: 'architecture-building-systems/CityEnergyAnalyst' reply@reply.github.com<mailto:reply@reply.github.com>; architecture-building-systems/CityEnergyAnalyst CityEnergyAnalyst@noreply.github.com<mailto:CityEnergyAnalyst@noreply.github.com> Cc: Mention mention@noreply.github.com<mailto:mention@noreply.github.com> Betreff: AW: [architecture-building-systems/CityEnergyAnalyst] Solar Potential Calculation on HQ (#2645)

Rey, you are the best! Many thanks.

Von: Reynold Mok notifications@github.com<mailto:notifications@github.com> Gesendet: Donnerstag, 9. April 2020 11:20 An: architecture-building-systems/CityEnergyAnalyst CityEnergyAnalyst@noreply.github.com<mailto:CityEnergyAnalyst@noreply.github.com> Cc: Sulzer, Matthias Matthias.Sulzer@empa.ch<mailto:Matthias.Sulzer@empa.ch>; Mention mention@noreply.github.com<mailto:mention@noreply.github.com> Betreff: Re: [architecture-building-systems/CityEnergyAnalyst] Solar Potential Calculation on HQ (#2645)

@matthiassulzerhttps://github.com/matthiassulzer you would have to rerun the radiation script also since the previous radiation results would still have the leap day.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/architecture-building-systems/CityEnergyAnalyst/issues/2645#issuecomment-611425711, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AM6FZIZGHUVEQKAIH4FB5I3RLWHMTANCNFSM4LNJFODA.

matthiassulzer commented 4 years ago

Hi Rey

I just identified another bug in the graph: Annual Costs for best individuals after 100 generations normalized to gross floor area --> the cost are showed in absolute numbers instead of US$ per m2 GFA

Best,

Matthias

Von: Sulzer, Matthias Gesendet: Montag, 20. April 2020 19:53 An: 'architecture-building-systems/CityEnergyAnalyst' reply@reply.github.com; 'architecture-building-systems/CityEnergyAnalyst' CityEnergyAnalyst@noreply.github.com Cc: 'Mention' mention@noreply.github.com Betreff: AW: [architecture-building-systems/CityEnergyAnalyst] Solar Potential Calculation on HQ (#2645)

… interesting: using Zürich SMA 2016 weather data, the error occurs. But using Zürich TMY 1990-2010 weather data, on error occurs.

Von: Sulzer, Matthias Gesendet: Montag, 20. April 2020 19:40 An: 'architecture-building-systems/CityEnergyAnalyst' reply@reply.github.com<mailto:reply@reply.github.com>; 'architecture-building-systems/CityEnergyAnalyst' CityEnergyAnalyst@noreply.github.com<mailto:CityEnergyAnalyst@noreply.github.com> Cc: 'Mention' mention@noreply.github.com<mailto:mention@noreply.github.com> Betreff: AW: [architecture-building-systems/CityEnergyAnalyst] Solar Potential Calculation on HQ (#2645)

Hi Rey

Everything worked out well with the HQ case…. up to now. I got the following error: City Energy Analyst version 3.1.0 Running cea radiation with the following parameters:

Best,

Matthias

Von: Sulzer, Matthias Gesendet: Donnerstag, 9. April 2020 11:30 An: 'architecture-building-systems/CityEnergyAnalyst' reply@reply.github.com<mailto:reply@reply.github.com>; architecture-building-systems/CityEnergyAnalyst CityEnergyAnalyst@noreply.github.com<mailto:CityEnergyAnalyst@noreply.github.com> Cc: Mention mention@noreply.github.com<mailto:mention@noreply.github.com> Betreff: AW: [architecture-building-systems/CityEnergyAnalyst] Solar Potential Calculation on HQ (#2645)

Rey, you are the best! Many thanks.

Von: Reynold Mok notifications@github.com<mailto:notifications@github.com> Gesendet: Donnerstag, 9. April 2020 11:20 An: architecture-building-systems/CityEnergyAnalyst CityEnergyAnalyst@noreply.github.com<mailto:CityEnergyAnalyst@noreply.github.com> Cc: Sulzer, Matthias Matthias.Sulzer@empa.ch<mailto:Matthias.Sulzer@empa.ch>; Mention mention@noreply.github.com<mailto:mention@noreply.github.com> Betreff: Re: [architecture-building-systems/CityEnergyAnalyst] Solar Potential Calculation on HQ (#2645)

@matthiassulzerhttps://github.com/matthiassulzer you would have to rerun the radiation script also since the previous radiation results would still have the leap day.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/architecture-building-systems/CityEnergyAnalyst/issues/2645#issuecomment-611425711, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AM6FZIZGHUVEQKAIH4FB5I3RLWHMTANCNFSM4LNJFODA.

matthiassulzer commented 4 years ago

… and there might be an anther calculation error in the graph: Installed Capacities for sys_42_0 - MBS Case Study HQ --> seasonal storage with 50MW capacity is not feasible

Best,

Matthias

Von: Sulzer, Matthias Gesendet: Dienstag, 21. April 2020 09:02 An: 'architecture-building-systems/CityEnergyAnalyst' reply@reply.github.com; 'architecture-building-systems/CityEnergyAnalyst' CityEnergyAnalyst@noreply.github.com Cc: 'Mention' mention@noreply.github.com Betreff: AW: [architecture-building-systems/CityEnergyAnalyst] Solar Potential Calculation on HQ (#2645)

Hi Rey

I just identified another bug in the graph: Annual Costs for best individuals after 100 generations normalized to gross floor area --> the cost are showed in absolute numbers instead of US$ per m2 GFA

Best,

Matthias

Von: Sulzer, Matthias Gesendet: Montag, 20. April 2020 19:53 An: 'architecture-building-systems/CityEnergyAnalyst' reply@reply.github.com<mailto:reply@reply.github.com>; 'architecture-building-systems/CityEnergyAnalyst' CityEnergyAnalyst@noreply.github.com<mailto:CityEnergyAnalyst@noreply.github.com> Cc: 'Mention' mention@noreply.github.com<mailto:mention@noreply.github.com> Betreff: AW: [architecture-building-systems/CityEnergyAnalyst] Solar Potential Calculation on HQ (#2645)

… interesting: using Zürich SMA 2016 weather data, the error occurs. But using Zürich TMY 1990-2010 weather data, on error occurs.

Von: Sulzer, Matthias Gesendet: Montag, 20. April 2020 19:40 An: 'architecture-building-systems/CityEnergyAnalyst' reply@reply.github.com<mailto:reply@reply.github.com>; 'architecture-building-systems/CityEnergyAnalyst' CityEnergyAnalyst@noreply.github.com<mailto:CityEnergyAnalyst@noreply.github.com> Cc: 'Mention' mention@noreply.github.com<mailto:mention@noreply.github.com> Betreff: AW: [architecture-building-systems/CityEnergyAnalyst] Solar Potential Calculation on HQ (#2645)

Hi Rey

Everything worked out well with the HQ case…. up to now. I got the following error: City Energy Analyst version 3.1.0 Running cea radiation with the following parameters:

Best,

Matthias

Von: Sulzer, Matthias Gesendet: Donnerstag, 9. April 2020 11:30 An: 'architecture-building-systems/CityEnergyAnalyst' reply@reply.github.com<mailto:reply@reply.github.com>; architecture-building-systems/CityEnergyAnalyst CityEnergyAnalyst@noreply.github.com<mailto:CityEnergyAnalyst@noreply.github.com> Cc: Mention mention@noreply.github.com<mailto:mention@noreply.github.com> Betreff: AW: [architecture-building-systems/CityEnergyAnalyst] Solar Potential Calculation on HQ (#2645)

Rey, you are the best! Many thanks.

Von: Reynold Mok notifications@github.com<mailto:notifications@github.com> Gesendet: Donnerstag, 9. April 2020 11:20 An: architecture-building-systems/CityEnergyAnalyst CityEnergyAnalyst@noreply.github.com<mailto:CityEnergyAnalyst@noreply.github.com> Cc: Sulzer, Matthias Matthias.Sulzer@empa.ch<mailto:Matthias.Sulzer@empa.ch>; Mention mention@noreply.github.com<mailto:mention@noreply.github.com> Betreff: Re: [architecture-building-systems/CityEnergyAnalyst] Solar Potential Calculation on HQ (#2645)

@matthiassulzerhttps://github.com/matthiassulzer you would have to rerun the radiation script also since the previous radiation results would still have the leap day.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/architecture-building-systems/CityEnergyAnalyst/issues/2645#issuecomment-611425711, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AM6FZIZGHUVEQKAIH4FB5I3RLWHMTANCNFSM4LNJFODA.

reyery commented 4 years ago

@matthiassulzer for the problem regarding solar radiation, there seems to be an error in the weather file reader when something else was merged. I have a fix for that and am testing now. For the other two, I would have to look further into them.

jimenofonseca commented 4 years ago

Hey rey, we did a fix when people included weather files with a leap year but without the 29th of feb.

It should work for both cases.

Is there an error?

Dr. Jimeno Fonseca Senior Researcher SEC | ETH Zurich

Read more about City Energy Dynamicshttps://www.jimenofonseca.com/

On 21 Apr 2020, 20:54 +0800, Reynold Mok notifications@github.com, wrote:

@matthiassulzerhttps://github.com/matthiassulzer for the problem regarding solar radiation, there seems to be an error in the weather file reader when something else was merged. I have a fix for that and am testing now. For the other two, I would have to look further into them.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/architecture-building-systems/CityEnergyAnalyst/issues/2645#issuecomment-617160554, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACEOXATIHU4FFUWIFWEFTITRNWJO7ANCNFSM4LNJFODA.

reyery commented 4 years ago

@JIMENOFONSECA I think there was a missing variable when you resolved the merge conflict. I will merge the fix soon

reyery commented 4 years ago

@matthiassulzer I am not too familiar with the calculation of Installed Capacities, could you create this in a new issue so that we can assign it to someone with that knowledge?

reyery commented 4 years ago

@matthiassulzer I have merged the fix for the weather reader to master. #2706