architecture-building-systems / CityEnergyAnalyst

The City Energy Analyst (CEA)
https://www.cityenergyanalyst.com/
MIT License
196 stars 66 forks source link

remove Tcs_sys_sup_C, Tcs_sys_re_C, Ths_sys_sup_C, Ths_sys_re_C in demand outputs #3064

Open jimenofonseca opened 2 years ago

jimenofonseca commented 2 years ago

Describe the bug The temperatures of supply and return of cooling are 0. @shanshanhsieh do you have an idea why that is the case?

To Reproduce Steps to reproduce the behavior:

  1. run demand simulation for a coololing case

Expected behaviour The temperatures of supply and return of cooling should not be 0.

Screenshots image

Hardware (please complete the following information):

shanshanhsieh commented 2 years ago

Hi @jimenofonseca , How would you like to use these outputs?

I think Tcs_sys_sup_C, Ths_sys_re_C and the equivalent for space heating are obsolete. As far as I know, they are not used anywhere else.

These outputs were being replaced by Tcs_scu_sup_C, Tcs_ahu_sup_C, and Tcs_aru_sup_C. (scu: sensible cooling unit, ahu: air handling unit, aru: air recirculating unit) When running DC simulations, the T_sup_target_DC and T_re_target_DC are being calculated according to which systems (scu, aru, ahu) are supplied by DC.

jimenofonseca commented 2 years ago

Oh i did not know that. If they are obsolete it would be great to take them down. The same for the massflowrstes_sys if there are any. We just found this to be confusing while improving the district cooling model with matthias… On 24 Nov 2021, 17:06 +0100, Shanshan Hsieh @.***>, wrote:

Hi @jimenofonseca , How would you like to use these outputs? I think Tcs_sys_sup_C, Ths_sys_re_C and the equivalent for space heating are obsolete. As far as I know, they are not used anywhere else. These outputs were being replaced by Tcs_scu_sup_C, Tcs_ahu_sup_C, and Tcs_aru_sup_C. (scu: sensible cooling unit, ahu: air handling unit, aru: air recirculating unit) When running DC simulations, the T_sup_target_DC and T_re_target_DC are being calculated according to which systems (scu, aru, ahu) are supplied by DC. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.