architecture-building-systems / CityEnergyAnalyst

The City Energy Analyst (CEA)
https://www.cityenergyanalyst.com/
MIT License
194 stars 61 forks source link

Surroundings helper behaves wrongly for custom building footprints #3495

Closed MatNif closed 6 months ago

MatNif commented 6 months ago

Describe the bug When uploading .shp files to CEA with entirely new building footprints for an area (e.g. in a redevelopment scenario), the surroundings helper would include all buildings that don't precisely match the uploaded footprints. This can easily lead to overlaps of uploaded buildings with existing buildings. A behaviour that is likely unexpected for many users.

To Reproduce Steps to reproduce the behavior:

  1. Create new Scenario and select "Import input files"
  2. Upload a .shp file with building-footprints that differ from the existing buildings in the area
  3. Run surroundings helper
  4. See error in Input Editor

Expected behaviour I think the easiest workaround here would be to change the checks in 'surroundings helper' to eliminate buildings that partially overlap with selected buildings in the area.

Screenshots image