Add German Building Database

ddceruti commented 4 months ago

German building stock database contribution by @Mar-Ges, @ululele and @ddceruti for CEA. Tested on CEA v3.35.2, based on the CH database. However, it does not include the "_NEW.xslx" files. This causes a known bug when viewing or editing the database in the Dashboard, which can be quick fixed (Issue #3432).

Details on assumptions, sources and method are located in the documentation.md file. Additional information is in the README.md file.

This database is detailed and validated in a conference paper currently under review. The citation is included in both .md files and will be updated as soon as possible.

Tagging @ShiZhongming to notify him that the pull request has been opened.

ShiZhongming commented 4 months ago

Dear @ddceruti, @ululele and @mar-ges,

Thank you very much for this! I will review it by tomorrow and come back to you. We aim to publish it by the Week of 18 March in the upcoming release of CEA v3.36.X.

Best, Zhongming

ShiZhongming commented 4 months ago

Dear @c0nb4.

I am tagging you here as a reviewer for this PR. Thank you for volunteering!

Best, Zhongming

ShiZhongming commented 4 months ago

Dear @ddceruti

I just preliminarily completed testing this PR. In general, it worked well. Thank you.

However, I have some minor questions as posted above. Besides, I would like to point out again the naming convention of the .csv under Folder user_types.

I would still suggest renaming them in English. Is it possible to replace MULTI_RES.csv with D_MFH.csv? I am raising this point as CEA assgins CEA use types to buildings when fetching data from OSM using the following conversion chart. Do you think the naming could be revised to facilitate such conversions? # OSM building category converters OSM_BUILDING_CATEGORIES = { 'residential': 'MULTI_RES', 'apartments': 'MULTI_RES', 'dormitory': 'MULTI_RES', 'terrace': 'MULTI_RES', 'nursing_home': 'MULTI_RES', 'social_facility': 'MULTI_RES', 'house': 'SINGLE_RES', 'bungalow': 'SINGLE_RES', 'cabin': 'SINGLE_RES', 'detached': 'SINGLE_RES', 'farm': 'SINGLE_RES', 'ger': 'SINGLE_RES', 'houseboat': 'SINGLE_RES', 'semidetached_house': 'SINGLE_RES', 'static_caravan': 'SINGLE_RES', 'hotel': 'HOTEL', 'office': 'OFFICE', 'civic': 'OFFICE', 'commercial': 'OFFICE', 'government': 'OFFICE', 'bureau_de_change': 'OFFICE', 'courthouse': 'OFFICE', 'embassy': 'OFFICE', 'post_office': 'OFFICE', 'townhall': 'OFFICE', 'industrial': 'INDUSTRIAL', 'retail': 'RETAIL', 'kiosk': 'RETAIL', 'bank': 'RETAIL', 'pharmacy': 'RETAIL', 'marketplace': 'RETAIL', 'supermarket': 'FOODSTORE', 'restaurant': 'RESTAURANT', 'fast_food': 'RESTAURANT', 'food_court': 'RESTAURANT', 'bar': 'RESTAURANT', 'biergarten': 'RESTAURANT', 'cafe': 'RESTAURANT', 'ice_cream': 'RESTAURANT', 'pub': 'RESTAURANT', 'hospital': 'HOSPITAL', 'clinic': 'HOSPITAL', 'dentist': 'HOSPITAL', 'doctors': 'HOSPITAL', 'veterinary': 'HOSPITAL', 'school': 'SCHOOL', 'kindergarten': 'SCHOOL', 'childcare': 'SCHOOL', 'driving_school': 'SCHOOL', 'language_school': 'SCHOOL', 'music_school': 'SCHOOL', 'university': 'UNIVERSITY', 'college': 'UNIVERSITY', 'library': 'LIBRARY', 'toy_library': 'LIBRARY', 'gym': 'GYM', 'sports_hall': 'GYM', 'pavilion': 'GYM', 'arts_centre': 'MUSEUM', 'cinema': 'MUSEUM', 'theatre': 'MUSEUM', 'parking': 'PARKING', 'carport': 'PARKING', 'garage': 'PARKING', 'garages': 'PARKING', 'hangar': 'PARKING', 'bicycle_parking': 'PARKING', 'charging_station': 'PARKING', 'motorcycle_parking': 'PARKING', 'parking_entrance': 'PARKING', 'parking_space': 'PARKING', 'taxi': 'PARKING'}

Another point is about CEA's auto-assigning CONSTRUCTION_STANDARD to buildings coming from OSM. Currently, the auto assign uses the year of construction. For your DE archetypes, the construction standards have an additional dimension of use types. We (The CEA Team) will need to update the script of this auto-assign. We will do this after we align the naming logic mentioned above. Meanwhile, I would like to get your consent for changing minorly of your DE database's code columns as it might neccessary to do so when we update the auto-assign script. This means, we will update your database from our end without asking you to do so under this PR. Do you think it is ok?

Thanks, Zhongming

ddceruti commented 4 months ago

Hi Zhongming, thanks a lot for your suggestions! Of course we will change the naming to fit CEA's standards as much as possible. I will implement all the comments directly and push a new version of the database. Lastly, we will discuss the naming conventions of the use_types internally and get back to you with a new version.

ddceruti commented 4 months ago

Hi, we updated several files to adapt to the naming conventions, including the system_references.txt for the use_types by @Mar-Ges and updated some documentation.

c0nb4 commented 4 months ago

Thanks for reaching out for review.

The following points are general remarks.

TABULA lack's data for Apartment Blocks after 1979. Hence, data is lacking in the typology. I've seen papers just copying the MFH Typology, e.g. https://www.researchgate.net/publication/378038367_A_modular_framework_for_a_dynamic_residential_building_stock_model_with_energy_retrofit_forecasts

Comments for the implementation:

Archetypes:

Description of IWU Typology for Non-Residential is different from description of Residential (2016 - ...) for 2010 / 2016 - onwards.
Typo in "Non-residentail" in column description 127-130 in the standard definition.
GDR buildings are currently not implemented.
Abbreviation NWG is short for Nichtwohngebäude (Non-Residential), further abbreviations are English.

Use-Types ( compared with: https://linkinghub.elsevier.com/retrieve/pii/S2210670723003050 and 18599-10)

Typo in metadata for D1-D13, in "Din 18599"
Schedule for D2-Buero, according to DIN18599-10 the usage time is from 7-18. In the file, it is from 8-18. What is the reason for this? Other schedules also differentiate from usage time in 18599.
Set points seem to be mixed up for D4, D8 (both), D6, D4 and D13.
Set point for D4 should be 21 degrees, according to the previous paper.

ShiZhongming commented 4 months ago

Hi @all Thanks for the updates. I just reviewed the second version of the DE Database and coming back with the following comments.

Typo: kindergarten instead of kindergarden
ENVELOPE.xlsx - Tab Window: column name should be GHG_win_kgCO2m2 instead of GHG_WINDOW_kgCO2m2
ENVELOPE.xlsx - Tabs Window, ROOF, WALL and FLOOR: missing columns Service_Life_win, Service_Life_roof, Service_Life_wall, and GService_Life_floor, respectively.

During the CEA Monthly Assembly next week - we will discuss the following:

DOUMENTATION.MD or reference.txt
Plans to intergrate _new.xlsx files.

ShiZhongming commented 4 months ago

Thanks for reaching out for review.

The following points are general remarks.

* TABULA lack's data for Apartment Blocks after 1979. Hence, data is lacking in the typology. I've seen papers just copying the MFH Typology, e.g. https://www.researchgate.net/publication/378038367_A_modular_framework_for_a_dynamic_residential_building_stock_model_with_energy_retrofit_forecasts

Comments for the implementation:

Archetypes:

* Description of IWU Typology for Non-Residential is different from description of Residential (2016 - ...)  for 2010 / 2016 - onwards.

* Typo in "Non-residentail" in column description 127-130 in the standard definition.

* GDR buildings are currently not implemented.

* Abbreviation NWG is short for Nichtwohngebäude (Non-Residential), further abbreviations are English.

Use-Types ( compared with: https://linkinghub.elsevier.com/retrieve/pii/S2210670723003050 and 18599-10)

* Typo in metadata for  D1-D13, in "Din 18599"

* Schedule for D2-Buero, according to DIN18599-10 the usage time is from 7-18. In the file, it is from 8-18.  What is the reason for this? Other schedules also differentiate from usage time in 18599.

* Set points seem to be mixed up for D4, D8 (both), D6, D4 and D13.

* Set point for D4 should be 21 degrees, according to the previous paper.

Thank you for reviewing the database as an expert in the German context. @ddceruti Could you take a look at this?

ddceruti commented 4 months ago

Thanks for your great feedback and detailed check of the database @c0nb4! I will try to clarify everything and think about the proposal of simply assigning MFH to the HR buildings like the publication did. We updated the use_types, but your feedback will still be implemented. I will also change the naming of NWG to the english version. @ShiZhongming I will correct the ENVELOPE.xslx errors and add the columns which are missing - I cloned an old version of the database which did not include them yet! I will correct the typo of kindergarten. I will be finishing up the work after the weekend, so expect an update on monday from my side.

ddceruti commented 4 months ago

GDR buildings are currently not implemented.

Also, I can add the GDR buildings next week, but that will take some additional time.

c0nb4 commented 4 months ago

I'm currently running a test simulation and try to continuously update feedback. Anyhow, thank you so much for this database. Really great work and I've been waiting for this since I've learned about CEA!

In the supply file:

the electricity sheet, the last row, seems to have a different format.
CAPEX for district heating is taken from CEA Switzerland. Good source in germany might be nPro: https://www.npro.energy/main/en/5gdhc-networks/price-cost-data

ddceruti commented 4 months ago

Thanks again for the feedback. I added eastern germany archetypes and updated some HVAC assembly informations.

In the supply file:

* the electricity sheet, the last row, seems to have a different format.

I updated the format.

* CAPEX for district heating is taken from CEA Switzerland. Good source in germany might be nPro: https://www.npro.energy/main/en/5gdhc-networks/price-cost-data

I updated some capex and efficiencies for the DISTRICT technologies with the danish energy agency reference, which is the most complete I know of... npro has some information but is missing efficiency and lifetime values. Here is the link: https://ens.dk/en/our-services/projections-and-models/technology-data/technology-data-generation-electricity-and

c0nb4 commented 3 months ago

Hey everyone,

I'm not sure on the current time frame, so I will update as long as this pull request has not been merged.

I do have two more questions:

Why is the type_cs mostly HVAC_Cooling_AS3? Shouldn't it be "none" so HVAC_Cooling_AS0? I'm refering to file: "Construction_Standard" page "HVAC_Assemblies"?
Where is Ea_WM2 "Peak specific electrical load due to computers and devices [W/m2]" defined?

ddceruti commented 3 months ago

Hi,

thanks again for your feedback @c0nb4 ! We will re check the schedules with @mar-ges

I updated the database with the service life, changed the cooling to AS0 (none) and the typo in GHG emissions of the windows. @ShiZhongming , what are we missing? What else do you need?

ShiZhongming commented 3 months ago

Hi @ddceruti

Sorry that I forgot to update you that we did not finalise this PR as @MatNif and I are working to merge the _NEW.xlsx files. We thought we it would be better that we fix the database and release the DE database both together for the upcoming release.

For the DE database itself, I just tested it a few times myself and I am coming back with two comments.

why are some cells highlighted in yellow as follows?
The following cells in Columns E and Rows 149-152 seem to be a typo.

After addressing these two comments and the newer ones from @c0nb4, I would say the DE Database is ready to be merged. We will include it into the upcoming release.

Thank you. Best, Zhongming

ShiZhongming commented 2 months ago

Hi @ddceruti

Did you have a chance to take a look at the comments above? We are ready to merge this PR for the upcoming release.

Best, Zhongming

ddceruti commented 2 months ago

Hi all, I updated the database with your comments. All ready from my part.

ShiZhongming commented 2 months ago

The DE Database is now merged.

Thank you @ddceruti @Mar-Ges @ululele. Speical thanks to @c0nb4 for the reviewing work.

architecture-building-systems / CityEnergyAnalyst

Add German Building Database #3521