Fixing interaction between energy potentials and supply system operation

[MatNif]

When performing the 'cascading' activation of the components installed in the supply system, the previous code would erroneously look at the availability of the demand from renewable energy potentials and grids independently of the component category.

This has now been fixed. With the new code:

• Main cooling/heating components (i.e. primary components) would check if their demand could be met by potentials or the grid prior to activation.
• Supply components (i.e. secondary components) would check if their demand can be satisfied by the remaining renewable energy potentials and/or the grid.
• Lastly, heat rejection components (i.e. tertiary components) would check if the heat they need to reject can be directly expulsed to the environment prior to their activation.

Additionally, a mistake was fixed for cogeneration plants, where the wrong energy carriers were attributed to their outputs.

[jimenofonseca]

Fun! matthias when do you have time to check it 30 min online? I just want to avoid misinterpreting this cool input.Your late afternoon? My morning? (7 am CH)Best, jimenoOn 5 Apr 2024, at 06:35, Mathias Niffeler @.***> wrote:When performing the 'cascading' activation of the components installed in the supply system, the previous code would erroneously look at the availability of the demand from renewable energy potentials and grids independently of the component category. This has now been fixed. With the new code:

Main cooling/heating components (i.e. primary components) would check if their demand could be met by potentials or the grid prior to activation. Supply components (i.e. secondary components) would check if their demand can be satisfied by the remaining renewable energy potentials and/or the grid. Lastly, heat rejection components (i.e. tertiary components) would check if the heat they need to reject can be directly expulsed to the environment prior to their activation.

Additionally, a mistake was fixed for cogeneration plants, where the wrong energy carriers were attributed to their outputs.

You can view, comment on, or merge this pull request online at:   https://github.com/architecture-building-systems/CityEnergyAnalyst/pull/3543

Commit Summary

b91d88b Update supply system operation b20e24b fix energy carriers for CogenPlants

File Changes (2 files)

M
cea/optimization_new/component.py
(4)

M
cea/optimization_new/supplySystem.py
(14)

Patch Links:

https://github.com/architecture-building-systems/CityEnergyAnalyst/pull/3543.patch https://github.com/architecture-building-systems/CityEnergyAnalyst/pull/3543.diff

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: @.***>

[MatNif]

Hi @jimenofonseca,

I'm sorry I missed this message. Let's check it sometime next week. How about Monday at 9 a.m. CET?

[reyery]

@MatNif the PR looks good to me. Do you have anything else to change? If not I would merge it.

[MatNif]

@MatNif the PR looks good to me. Do you have anything else to change? If not I would merge it.

No, nothing else to add. You can go ahead and merge.