search

architecture-building-systems / CityEnergyAnalyst

The City Energy Analyst (CEA)
https://www.cityenergyanalyst.com/
MIT License
188 stars 59 forks source link

Consider adjacent walls by default #3576

Closed martin-mosteiro closed 1 month ago

martin-mosteiro commented 2 months ago

As discussed in issue #3555, adjacent walls were not considered by CEA by default. This means that there was artificial insolation on attached walls and adiabatic surfaces were neglected (i.e., walls were assumed to be in contact with exterior air). This is not consistent with the SIA and ISO standards on which the calculation is based, but it does have the advantage of somewhat lower simulation times.

Therefore, the parameter has been redefined: rather than users whether they would like to consider-intersections, they are now asked whether they would like to neglect-adjacent-buildings. The default value is False, as that is the more correct simulation method, but users may set this parameter to True if they are okay with less accurate simulations in exchange for somewhat faster simulation times.

ShiZhongming commented 1 month ago

Looks good to me too. Thank you @martin-mosteiro Will merge when we fix the reference-case tests.