architecture-building-systems / RC_BuildingSimulator

A Resistance Capacitance Model for an Energetic Simulation of a Building
Other
96 stars 36 forks source link

Tested for Python 3 Compatibility and Included Vagrant Virtual Environment #25

Closed pjayathissa closed 6 years ago

pjayathissa commented 6 years ago

New Changes

pjayathissa commented 6 years ago

Yo @JustinZarb , can you review this merge

Cheers

PJ

pjayathissa commented 6 years ago

Hi Justin

Thanks for taking a look. Going through your points

1) Yes this is a bit strange. I will take it on as an issue, and solve it in the next pull request. https://github.com/architecture-building-systems/RC_BuildingSimulator/issues/27

2) Naming Change: This is a good point. It requires a more refactoring of the code. In the next pull request I plan on doing a big refactor anyway (renaming the whole module) so I can include it there. For this pull request, I just wanted to make the old code python 3 compatible https://github.com/architecture-building-systems/RC_BuildingSimulator/issues/26

3) Vagrant: You can find the documentation in the wiki https://github.com/architecture-building-systems/RC_BuildingSimulator/wiki/Vagrant-Environment Have a go if you have time, and let me know how you found it