architecture-building-systems / RC_BuildingSimulator

A Resistance Capacitance Model for an Energetic Simulation of a Building
Other
95 stars 35 forks source link

Phi HC,nd removal from multiple equations #58

Open ghost opened 2 years ago

ghost commented 2 years ago

Hi,

Thank you for this amazing code first of all. I was just wondering why was the phi HC,nd omitted from equations C5, C10 and C11 in building_physics.py, even though it is mentioned in the standard. Wouldn't removing them change the unrestricted heat demand?

Best, Kamal

pjayathissa commented 2 years ago

Dear Kamal

I'll post my answer here as it's a common question I get.

Phi HC,nd is removed as it has been refactored within the emissions system classes to give more flexibility in how they are distributed in the building space. I really should update the code with a comment that highlights this and will reopen this as a todo