architecture-building-systems / hive

Rhino Grasshopper plug-in for quick & dirty building simulation
https://www.food4rhino.com/en/app/hive
GNU General Public License v3.0
31 stars 4 forks source link

Migrate Solar (simple panel) from Hive.Core to Hive.IO #693

Closed maxenceryan closed 2 years ago

maxenceryan commented 2 years ago

Issues

Closes #687

Description

TODO

Check how to properly add reference to SolarModel.dll. I asusme it will build it together in C#

Checklist

christophwaibel commented 2 years ago

@maxenceryan also looks good to me! I tried to merge the master branch, but there were some too many conflicts to resolve quickly. Could you do that? After that, good to merge from my side! Cheers!

I haven't checked yet, if removing the solar.py / solar.json from the build.cmd and setup.nsi will break anything (main gh template)

maxenceryan commented 2 years ago

merging this. @christophwaibel i took out the solar ghpy from the build.cmd and nsi script (just commented out, check out commit 80bcea7 . So if you get some missing component errors, you can simply revert what happened there and it should be fine. just dont save the gh files and reinstall hive with the solar ghpy :)