architecture-building-systems / hive

Rhino Grasshopper plug-in for quick & dirty building simulation
https://www.food4rhino.com/en/app/hive
GNU General Public License v3.0
31 stars 4 forks source link

replace electricityMerger ghpython component in Core #701

Closed christophwaibel closed 2 years ago

christophwaibel commented 2 years ago

Describe the bug There are custom ghpython components for merging grid electricity in the main template. They use import Hive.IO.EnergySystems, which will not work anymore once we remove the epw_reader.py component from honeybadger (#692 ). In that python script, we load in dependencies that make this import work. But once we create a proper Hive.IO component for merging electricity, we won't need these dependencies anymore.

clr.AddReferenceToFileAndPath(os.path.join(path, "Libraries\Hive", "Hive.IO.gha"))
import Hive.IO.EnergySystems as ensys

To Reproduce remove Hive.Core.epw_reader.ghpy from the grasshopper components libraries folder and the main hive template will stop working properly.

Screenshots image

Software

Additional context related comment from earlier PR

ChrisZenhub commented 2 years ago

To Do:

ChrisZenhub commented 2 years ago

possible relation with #707