search

architecture-building-systems / hive

Rhino Grasshopper plug-in for quick & dirty building simulation
https://www.food4rhino.com/en/app/hive
GNU General Public License v3.0
31 stars 4 forks source link

C# simple solar very slow with many surfaces #713

Closed christophwaibel closed 2 years ago

christophwaibel commented 2 years ago

Describe the bug The migrated C# component GhSolarUnobstructed.cs is extremely slow with many inputs. The problem is likely rooted in RegisterInputParams: it reads tilt angles and azimuths in as lists, however surface area only as item. Therefore, it probably conducts p.CalcIrradiationMT way too many times.

Expected behavior Should be faster. Change inputs either all to items, or all (include surface area) to lists and make proper multi-threading.

Software

ChrisZenhub commented 2 years ago

@philipschulz strangely, I cannot reproduce it with the current master image.png

top is python, bottom is c#, testing with 100 PV surfaces.

If you also can't reproduce it, you can close this issue