architecture-building-systems / hive

Rhino Grasshopper plug-in for quick & dirty building simulation
https://www.food4rhino.com/en/app/hive
GNU General Public License v3.0
31 stars 4 forks source link

Solar Simulations should use trimmed surface #714

Open christophwaibel opened 2 years ago

christophwaibel commented 2 years ago

Describe the bug When conducting solar simulations, the original untrimmed surface geometry is used. This is very unintuitive for the user, because the user usually only sees the trimmed geometry. The problem becomes visible when displaying the coloured mesh with irradiation values. See screenshot below

Expected behavior Simulation should by default work with the trimmed geometry,

Screenshots

image

Software

ChrisZenhub commented 1 year ago

related issue #626

philipschulz commented 12 months ago

@ChrisZenhub this seems to be caused simply by the component that generates the mesh from the referenced surface, as that apparently ignores the trim and makes a mesh from the underlying untrimmed surface. Frustratingly, setting the bool option "Allow faces to overhang trims" to False on that component doesn't seem to fix this behaviour in the expected way...

Image

christophwaibel commented 12 months ago

hmm ok thanks @philipschulz . can you propose an alternative workflow for the template, where this doesn't happen? Or maybe make a new gh component that ensures that always the trimmed geometry is used? Or, actually what I prefer: implement it in the solar model that it always uses the trimmed geometry (the one, that is shown on the rhino display)