architecture-building-systems / hive

Rhino Grasshopper plug-in for quick & dirty building simulation
https://www.food4rhino.com/en/app/hive
GNU General Public License v3.0
31 stars 4 forks source link

Demand simulation only works with windows #715

Closed christophwaibel closed 2 years ago

christophwaibel commented 2 years ago

Describe the bug This bug keeps coming back with every Hive version ;-( Demand simulation only works with windows. It should also work for a box without windows.

Screenshots

image

Software

how to reproduce Get the current master, install it. Open the main template file (...\hive\GrasshopperExamples\LectureExercises\EaCS3_E04_Hive_Template.gh), and remove the windows from the Hive-Building-input. The simulation will not be able to run and no results will be produced.

Expected Behavior Demand simulations should also work without windows on a building.

ChrisZenhub commented 2 years ago

to be checked, but I think the respective GH_input_params in the GH_Component just needs to be set to "optional".

If this does not do the trick, you should compare the original python code that has been phased out with the new c# code. PR #703 and issue #688

ChrisZenhub commented 2 years ago

ok strange... I can't reproduce this bug anymore @mmatache25 please also try with your Mac and if you also don't get this bug, close this issue

mmatache25 commented 2 years ago

@christophwaibel the demand simulation works with or without windows, it works as expected.