architecture-building-systems / hive

Rhino Grasshopper plug-in for quick & dirty building simulation

https://www.food4rhino.com/en/app/hive

GNU General Public License v3.0

31 stars 4 forks source link

677 adding bipv #717

Closed mmatache25 closed 2 years ago

mmatache25 commented 2 years ago

adding BIPV as separate technology to the Energy Systems Hizard

Issues

Closes #677

Closes

Description

Adding BIPV as option in the combo box of the energy systems input form similar to PV.

Checklist

[x] Remove debugging artifacts (if needed)
[x] Rebuild the Setup_Hive.exe
[ ] Update Hive Wiki (if needed)
[ ] Update InformationalVersion attribute in Hive.IO/Properties/AssemblyInfo.cs (if it's a new release)
[x] Update most important Grasshopper template(s); as of now /GrasshopperExamples/LectureExercises/EaCS3_E04_Hive_Template.gh

christophwaibel commented 2 years ago

I just figured, a subclass is also recognized by its base class and remains a subclass, so it's actually enough to scan for Photovoltaic only

                    //case BuildingIntegratedPV valueBIPV:
                    //    srfBasedTech.Add(valueBIPV); break;
                    case Photovoltaic valuePV:                      
                        srfBasedTech.Add(valuePV); break;