architecture-building-systems / hive

Rhino Grasshopper plug-in for quick & dirty building simulation

https://www.food4rhino.com/en/app/hive

GNU General Public License v3.0

31 stars 4 forks source link

529 GH_Visualizer Axis Limits Input #723

Closed philipschulz closed 2 years ago

philipschulz commented 2 years ago

Axis Limits Input

Issues

Closes #529

Description

Draws a box around the clickable Area when hovering over the Y-Axis
Double clicking in that area brings up the Axis Limit Input Window

Checklist

[ ] Remove debugging artifacts (if needed)
[x] Rebuild the Setup_Hive.exe
[ ] Update Hive Wiki (if needed)
[ ] Update InformationalVersion attribute in Hive.IO/Properties/AssemblyInfo.cs (if it's a new release)
[ ] Update most important Grasshopper template(s); as of now /GrasshopperExamples/LectureExercises/EaCS3_E04_Hive_Template.gh

christophwaibel commented 2 years ago

Hi Philip, awesome! Works pretty well on my computer, no performance issues. But then, I have a fast CPU... I suggest some improvements:

when the unit is set to /m2, the axis form should also change it's unit / range correspondingly
The box should not appear in the gains-vs-losses and not in the Amr plots:

ChrisZenhub commented 2 years ago

@christophwaibel try performance also with Macbook

christophwaibel commented 2 years ago

@christophwaibel try performance also with Macbook

performance of visualizer is fine on Parallels, Macbook with 2.3GHz i7

philipschulz commented 2 years ago

@christophwaibel Looking into it, the Axis Limit Input currently completely lacks the ability to edit the axis when in kwh/m2 viewmode, is that something that should change? Because that is why the numbers/units don't change when switching to normalized per m2 view

philipschulz commented 2 years ago

And I'll have to change that the axis input also appears and the box is drawn when on the "Solar Gains per Windows" view

christophwaibel commented 2 years ago

And I'll have to change that the axis input also appears and the box is drawn when on the "Solar Gains per Windows" view

Hey @philipschulz can you make a new issue for those? Let's merge this PR first

christophwaibel commented 2 years ago

@philipschulz it works on the energy demand plot, but now it unfortunately is also deactivated on the Solar Gains plot

philipschulz commented 2 years ago

@christophwaibel Yes but didn't you say I should open a new issue for that, so that this PR could be closed?

christophwaibel commented 2 years ago

@christophwaibel Yes but didn't you say I should open a new issue for that, so that this PR could be closed?

oh I see, misunderstanding. I though you were referring to the axis input form only. Please still add the double click for the Solar Gains plot to this PR. Thanks!

philipschulz commented 2 years ago

@christophwaibel The axis box now works correctly on all necessary plots

christophwaibel commented 2 years ago

works, thanks @philipschulz !