search

architecture-building-systems / hive

Rhino Grasshopper plug-in for quick & dirty building simulation
https://www.food4rhino.com/en/app/hive
GNU General Public License v3.0
31 stars 4 forks source link

EnergySystems Hizard not always showing missing-Surface-Warning #746

Closed christophwaibel closed 1 year ago

christophwaibel commented 2 years ago

Describe the bug In the Energy Systems Hizard, we can select PV / BIPV technologies. These need to be assigned to a specific surface geometry, otherwise they won't be included in the electricity generation. As this is "hidden" in the hizard, we implemented a warning message in an earlier PR #625 that also turns the component orange. It would inform the user that there are PV techs in the hizard that have not been assigned to any actual surface. This feature works usually, but not in the following situation (see "To Reproduce")...

To Reproduce Steps to reproduce the behavior:

  1. Open the template file Hive_FullTemplate.gh
  2. Navigate to the EnergySystems Hizard
  3. Change the U, V parameters of the mesh component that connects to "Mesh/SolarTechProperties" of the Hizard. This will change the surface ID and thus clear it from the current PV assignment in the Hizard
  4. You will see that the hizard will not turn orange as it should and that no warning message is created

Expected behavior Upon changing anything the input surface (e.g., the U,V parameters), it will clear the assignment in the Hizard, and that should also trigger a warning. See screenshots

Screenshots Changing U,V will clear assignment, but no warning and no orange component: image

After opening and closing the hizard, it will trigger the warning correctly though: image

Software