architecture-building-systems / hive

Rhino Grasshopper plug-in for quick & dirty building simulation
https://www.food4rhino.com/en/app/hive
GNU General Public License v3.0
31 stars 4 forks source link

Natural Ventilation Check Box doesnt do anything #752

Closed christophwaibel closed 1 year ago

christophwaibel commented 1 year ago

Describe the bug In the building hizard, tab "Internal Gains", there is a "Natural Ventilation?" Checkbox at the bottom. First of all, it can't be checked (the state of the checkbox is not maintained). This can be solved by adding an EventHandler to BuildingInputForm.Designer.cs (checkBoxNaturalVentilation_CheckedChanged); similar to the checkbox for AdaptiveComfort. However, it doesn't change anything in the loads / losses. Upon checking sia380.cs, line 472 & 477, I can see that Vdot_nat_vent_constant is unused.

Expected behavior Natural ventilation should do something. Needs to be fixed in sia380.cs

Software

Additional context The checkbox bug is fixed in branch: https://github.com/architecture-building-systems/hive/tree/Natural-Ventilation