search

architecture-building-systems / revitpythonshell

An IronPython scripting environment for Autodesk Revit and Vasari
MIT License
494 stars 113 forks source link

Fix for completion error with callables #45

Closed PMoureu closed 7 years ago

PMoureu commented 7 years ago

error thrown with a dot after ()

doc.GetType().

daren-thomas commented 7 years ago

Wow! Thanks! Looks good to me. I'm going to merge this without checking it, since it is a small change that won't break existing functionality. Thank you so much for contributing :)

PMoureu commented 7 years ago

Thanks! I saw that the Ironlab use the same check, maybe we can provide others enhancements by merging whats mergeable in both project, i will take a look at this.

I also tested Innosetup, i managed to provide an installer for the Revit2015 fix. I used the unicode version of Innosetup, so the output file is slightly larger, is this problematic ?

daren-thomas commented 7 years ago

I don't think so. But I think I should probably make the installers on my machine. I'll set some time aside for that this week.