architecture-building-systems / revitpythonshell

An IronPython scripting environment for Autodesk Revit and Vasari
MIT License
502 stars 116 forks source link

ETA for Revit 2018 Installer? #56

Closed eirannejad closed 7 years ago

abatod commented 7 years ago

Waiting... :-)

daren-thomas commented 7 years ago

Oh, Revit 2018 is out? I guess I need to get my license renewed... I don't have a plan right now, but I might have some time end of the week.

daren-thomas commented 7 years ago

BTW: anyone want to help beta-testing the installer when it comes out?

htlcnn commented 7 years ago

I'm using Revit 2018 and am willing to test

daren-thomas commented 7 years ago

Here is a preliminary version: https://www.dropbox.com/s/jcdq5mwzsig0w45/Setup_RevitPythonShell_2018.iss?dl=0

I'd be interested to know of any problems...

htlcnn commented 7 years ago

Excuse me, how do I use this .iss file to install?

eirannejad commented 7 years ago

You gotta combile RPS on your machine, install InnoSetup tool that reads the ISS files. Then create the setup package from the ISS file

htlcnn commented 7 years ago

.iss file contains paths to files that I don't have on my computer, neither can I find them on this repo. How can I get these files?

eirannejad commented 7 years ago

The RPS code needs to be compiled for InnoSetup to be able to find the files

htlcnn commented 7 years ago

Then I'm supposed to have Visual Studio on my computer and know how to build a C# project to dll files?

eirannejad commented 7 years ago

Yeap. Or just wait till Daren publishes the exe installer which should be soon.

daren-thomas commented 7 years ago

@htlcnn I'm very sorry. In my rush to provide you with a setup file to test while I was on vacation, I accidentally sent the wrong file. Try this one instead: https://www.dropbox.com/s/h55ljwvy5weohrj/2017.07.24_Setup_RevitPythonShell_2018.exe?dl=0

abatod commented 7 years ago

image When open Revit 2018, this window appear. After open it, looks working well.

daren-thomas commented 7 years ago

hm... @abatod: do you have a manual installation that might be in the way?

abatod commented 7 years ago

Just downloaded this file and installed. https://www.dropbox.com/s/h55ljwvy5weohrj/2017.07.24_Setup_RevitPythonShell_2018.exe?dl=0 After close that window, pythonshell woks fine. Actually I installed in two machines. One has already installed phytonshell 2017 and another one is just new installed. Both of they shows me that error when open Revit 2018. Anyhow thank you for developing PythonShell.

daren-thomas commented 7 years ago

Ah yes... I get that error too. Wait. Let me investigate.

htlcnn commented 7 years ago

I tried to compile rps myself and got that error too. Rps didn't work either. Compiling the dlls didn't go on very well, revitpythonshell project seems to reference 2014 revitapi and revitapiui. I tried to change to 2018 dlls and set target framework to 4.6 but didn't succeed.

daren-thomas commented 7 years ago

I just pushed a fix for the issue on loading and updated the setup file linked above. @abatod: maybe you could check the error again?

daren-thomas commented 7 years ago

@htlcnn before compiling, make sure you select the correct solution configuration. it should be "Debug 2018". Then, the solution should reference the proper APIs...

CyrilWaechter commented 7 years ago

On my computer it solved the error message (got the same as @abatod). I tried some stuff in console, everything seems to work fine. Thanks a lot @daren-thomas we are now ready to move on 2018.1 ^^

htlcnn commented 7 years ago

Recent update fixed the error. RPS runs well on Revit 2018.1 (Windows 7 x64). Thank you very much @daren-thomas ! By the way, last time I checked there was no "Debug 2018" configuration, only 2017 and prior. I tried to create a new config named Debug 2018 based on Debug 2017, set target framework to 4.6 but I still didn't have AvalonEdit. I guess I'll have to learn some more C# and VS to be able to build RPS myself :grin:

daren-thomas commented 7 years ago

OK. I've created a release and updated the readme page to link to the installer. Thank you for your help everyone!