search

architecture-building-systems / revitpythonshell

An IronPython scripting environment for Autodesk Revit and Vasari
MIT License
502 stars 116 forks source link

Improved auto-completion. Fix paste at cursor bug. #59

Closed DanRumery closed 7 years ago

DanRumery commented 7 years ago

Hi Daren

I've incorporated a couple of improvements to the auto-completion functionality. This expands ctrl+space auto-complete to auto-complete on partial names (not just immediately after a dot), which includes global names (i.e. in the absence of a preceding dot, global names are matched). Auto-complete will now work inside expressions involving parentheses or brackets, e.g. completing an argument to a function, inside an expression, etc.). Underscores are allowed as a part of the auto-complete name (quite common in Revit API enums) which prevents the auto-complete window from closing when typing them.

Also added a fix to pasting text in the interpreter window so that now, if nothing is selected, the text is inserted at the cursor position as opposed to being pasted at the end of the line.

Let me know of any questions or code formatting improvements / comments needed.

[I have more improvements on the way if you'd like! (e.g. Save as, show name of current script filename in title bar, asterisk for modified / unsaved script file, etc.). Also a dark themed UI!]

DanRumery commented 7 years ago

Hi Daren

Just checking in, do you think these changes are useful? I can break them up more so it's easier to review if that's an issue...

daren-thomas commented 7 years ago

Hi @DanRumery, I'm truly sorry that I haven't gotten around to reviewing your pull request. I'm super stoked you created one! I'm just very busy right now - just got back from vacation and need to finish a sprint by Thursday... This is on my list!

daren-thomas commented 7 years ago

hey, this works! awesome!!

DanRumery commented 6 years ago

Great!! Thanks Daren. Hope people find it a useful improvement.