search

architecture-building-systems / sia_380-1-full_version

This code is the python implemented form of SIA380-1. It is not a simplified version.
4 stars 1 forks source link

Inconsistent windows parameter documentation #107

Closed kuhnal closed 3 years ago

kuhnal commented 3 years ago

Compare simulation_engine.py line 35 vs. 738 (maybe check in the calculation_UBP branch)

Calculations are done based on documentation in 738, I am quite sure that this is correct --> as defined in simulation_coordination ln. 170 (I was a bit confused first, as I assumed the definition in simulation_engine ln. 35 to be correct) Please confirm :)

Linwal commented 3 years ago

Yes, I can confirm that the definition is |Orientation| Area | U-value | g-value | I checked this in the monthly heating and cooling demand calculation and adapted the mentioned comment in line 35. This will be updated in the next push.

Thank you @kuhnal for the bug report.