search

architecture-building-systems / sia_380-1-full_version

This code is the python implemented form of SIA380-1. It is not a simplified version.
4 stars 1 forks source link

system dicionary for heating wrong #95

Closed Linwal closed 4 years ago

Linwal commented 4 years ago

The system dictionary for heating systems designates 'None' to direct heater. This will lead to a wrong assumption of dhw heating.

Linwal commented 4 years ago

This is not an issue as long as the heating system is the same as the dhw heating system. However if there is no heating system but a dhw heating system, this automatically assumes that the dhw is produced by a direct heater.

Linwal commented 4 years ago

Quick fix:

@kuhnal : Is this a problem for you?

Linwal commented 4 years ago

I'll push the quick fix soon.

kuhnal commented 4 years ago

Nein, das ist kein problem

Am 10.11.2020 um 14:09 schrieb Linwal notifications@github.com<mailto:notifications@github.com>:

Quick fix:

@kuhnalhttps://github.com/kuhnal : Is this a problem for you?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/architecture-building-systems/sia_380-1-full_version/issues/95#issuecomment-724690920, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ARGZYJJ3ZD7AXN5G4DYJ53LSPE3OZANCNFSM4TQUF5LQ.

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/architecture-building-systems/sia_380-1-full_version/issues/95#issuecomment-724690920", "url": "https://github.com/architecture-building-systems/sia_380-1-full_version/issues/95#issuecomment-724690920", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Linwal commented 4 years ago

Is fixed and pushed to master. #97