architectury / architectury-api

An intermediary api aimed at easing development of multiplatform mods.
https://discord.architectury.dev/
GNU Lesser General Public License v3.0
315 stars 56 forks source link

Registry Replacements (#430) #435

Closed qyl27 closed 5 months ago

qyl27 commented 1 year ago

Replace vanilla items with register() on fabric.
(Tested on my machine.)

MaxNeedsSnacks commented 9 months ago

Hmm, honestly I would prefer if registry replacement was explicit on both instead of implicit, so maybe we should instead consider making a registerOrOverride method?

qyl27 commented 9 months ago

Hmm, honestly I would prefer if registry replacement was explicit on both instead of implicit, so maybe we should instead consider making a registerOrOverride method?

Well, maybe that's right.
I will change it to a explicit method named registerOrOverride.

shedaniel commented 8 months ago

After some discussion on Discord, I believe we don't want to support registry replacements seeing how NeoForge no longer supports it after the Registry Rework and fabric never encouraged it. Alternative solutions should be used instead, albeit mixins or etc.

Some checks can be added to the forge register() method to warn potential registry replacements instead.

qyl27 commented 8 months ago

After some discussion on Discord, I believe we don't want to support registry replacements seeing how NeoForge no longer supports it after the Registry Rework and fabric never encouraged it. Alternative solutions should be used instead, albeit mixins or etc.

Some checks can be added to the forge register() method to warn potential registry replacements instead.

Ah, okay.

Jab125 commented 5 months ago

After some discussion on Discord, I believe we don't want to support registry replacements seeing how NeoForge no longer supports it after the Registry Rework and fabric never encouraged it. Alternative solutions should be used instead, albeit mixins or etc.

Some checks can be added to the forge register() method to warn potential registry replacements instead.