[1.20.1 Forge] java.lang.Exception: Mod Loading has failed

[katubug]

Crash on startup of heavily modded game. It brought me to this screen: https://i.imgur.com/X2Ej8Es.png

The only change I made was deleting a standalone mod from the modlist. I do not believe that's relevant.

Crash report and latest log: https://gist.github.com/katubug/aa879f4aa2d8cff1f007c8fd0484350d

I'm using architectury-9.1.12-forge.jar, Forge is version 47.2.17

Thanks for your time!

[katubug]

Just started up the game without issue. I'm not sure what could have caused it, but I guess it's fine now? I'll leave this open in case you want to look at it, but otherwise feel free to close the issue.

[Juuxel]

at net.minecraft.client.color.item.ItemColors.handler$znn000$embeddium$preRegisterColor

Appears to be an issue with Embeddium, not really sure what. I don't think it's related to Architectury.

[katubug]

I'll chalk this one up to "modded mc be like that sometimes," but I'll keep the embeddium thing in mind in case it keeps happening. Thanks!

[ChiefArug]

FastUtil collections are not thread safe and do not check for thread safety like the built in collections, so this is likely a concurrent modification issue, meaning it will happen sporadically. Definitely something you should report to embeddium.

[katubug]

I've been told by embeddium "This is their bug, they are registering colors on a worker thread instead of queuing the work properly"

[embeddedt]

This appears to be an Architectury bug, AFAIK the vanilla color map is not thread-safe and so event.enqueueWork should be used inside the event handler.

[Juuxel]

Ah, I see. I'll reopen this for further investigation then.