search

architectury / architectury-api

An intermediary api aimed at easing development of multiplatform mods.
https://discord.architectury.dev/
GNU Lesser General Public License v3.0
306 stars 55 forks source link

NeoForge 1.20.2 Holder does not implement Supplier, resulting in FluidStack crash. #484

Closed brandon3055 closed 3 months ago

brandon3055 commented 3 months ago

In NeoForge 20.2.59-beta Supplier was removed from net.minecraft.core.Holder

Commit: https://github.com/neoforged/NeoForge/pull/257/commits/ed1b47716277689ddaa4d0743b8cf81011922eb3

This is the patch that was removed: https://github.com/neoforged/NeoForge/blob/1ba480f54685088db109e719081d23fb5bc3848e/patches/net/minecraft/core/Holder.java.patch

As a result, FluidStack creation via FluidStack#create(FluidStack, long) crashes with: java.lang.IncompatibleClassChangeError: Class net.minecraft.core.Holder$Reference does not implement the requested interface java.util.function.Supplier Full Crash: https://ss.brandon3055.com/ebe85

Jab125 commented 3 months ago

wasn't that fixed in https://github.com/architectury/architectury-api/pull/483?

brandon3055 commented 3 months ago

wasn't that fixed in #483?

That fix appears to be for 1.20.4, It's still broken in 1.20.2

shedaniel commented 3 months ago

Should be closed by #485