search

architectury / architectury-api

An intermediary api aimed at easing development of multiplatform mods.
https://discord.architectury.dev/
GNU Lesser General Public License v3.0
306 stars 55 forks source link

[1.20.1] LIVING_CHECK_SPAWN event overrides PortingLib's version of the same event #488

Open TheWinABagel opened 3 months ago

TheWinABagel commented 3 months ago

Porting lib uses ModifyExpressionValue, (see here) which is overriden by this this redirect https://github.com/architectury/architectury-api/blob/cd74016d85b562affb21890cb8796b1e34ac2ca9/fabric/src/main/java/dev/architectury/mixin/fabric/MixinNaturalSpawner.java#L40 Changing this from a redirect to a Mixin extras ModifyExpressionValue would solve this incompatibility as the event would chain instead

LlamaLad7 commented 3 months ago

The ModifyExpressionValue will already modify the result of this redirect. They already chain.