search

architectury / architectury-api

An intermediary api aimed at easing development of multiplatform mods.
https://discord.architectury.dev/
GNU Lesser General Public License v3.0
306 stars 55 forks source link

Port to 1.20.6 #494

Closed Jab125 closed 1 month ago

Jab125 commented 2 months ago

Should be a very quick port.

shedaniel commented 2 months ago

Do we need a port? Doesn't it just works?

Jab125 commented 2 months ago

Do we need a port? Doesn't it just works?

We'll have to port in the future anyways, since I doubt NeoForge would keep maintaining 20.5 after 1.20.6 is released.

shedaniel commented 2 months ago

Yeah don't worry about that for now, we/I can do that when that's needed, we do that for older similar versions too

Jab125 commented 1 month ago

I've also fixed a bug with void acceptAfter(ItemStack after, ItemStack stack, CreativeModeTab.TabVisibility visibility); and void acceptBefore(ItemStack before, ItemStack stack, CreativeModeTab.TabVisibility visibility); where on NeoForge, it was unable to actually place items in the correct locations.

Jab125 commented 1 month ago

Also requesting the creation of a 1.20.6 branch to merge this into.