architectury / architectury-api

An intermediary api aimed at easing development of multiplatform mods.
https://discord.architectury.dev/
GNU Lesser General Public License v3.0
305 stars 54 forks source link

MenuRegistry in 1.21 NeoForge #517

Open gigabit101 opened 2 weeks ago

gigabit101 commented 2 weeks ago

MenuRegistry.registerScreenFactory() does not seem to be working in NeoForge 1.21 however using NeoForge's RegisterMenuScreensEvent is working fine.

This only effects NeoForge and the MenuRegistry works fine in Fabric

Luligabi1 commented 2 weeks ago

Had the same issue on 1.20.6; I assume it doesn't even get to call impl, since there were no errors when attempting to register the same screen twice...

tksonix commented 2 weeks ago

Same here, happens on 1.20.6 neoforge. It calls the registration but failed to register it in HandledScreens.PROVIDERS

tksonix commented 2 weeks ago

Also one thing I noticed that, MenuRegistry does work in fabric, but there are about 50/50 chance it fails to register.