architectury / architectury-documentations

Source of documentations of architectury.
https://architectury.github.io/architectury-documentations/
2 stars 10 forks source link

Better Documentation on The BiomeModfifcation API #2

Closed maximumpower55 closed 3 years ago

maximumpower55 commented 3 years ago

you should have like a example for like custom ores and custom structures

Like how to add a ore how to add a structure

ghost commented 3 years ago

The Biome modification API should be marked as deprecated, you can do it all with vanilla jsons

ghost commented 3 years ago

https://minecraft.gamepedia.com/Custom_world_generation

shedaniel commented 3 years ago

This is not how it works, this API allows you to post modify builtin or dynamic biomes so you can add your features.

Doing this with datapacks requires overriding the entire json and will not be compatible with other mods.

ghost commented 3 years ago

JSON can do that too? Features that are called by ConfiguredFeatures? The feature has a predicate to if it can spawn:

Eg: - If surrounded by Stone, generate ore.

Technici4n commented 3 years ago

Please, if you think json can do everything that java, let's just stop modding with java and start using json for everything.

In general, please refrain from commenting when you clearly don't understand why this API is necessary in the first place... FYI it's deprecated in fabric API because it's experimental, not because it's replaced by json.

ghost commented 3 years ago

What did fabric API have to do with this? I'm saying it should be deprecated because vanilla Minecraft has these features in datapacks.

shedaniel commented 3 years ago

Defining such ConfiguredFeature jsons do not automatically add your feature to the world.

ghost commented 3 years ago

Then you register the ConfiguredFeature to the Registry and then it's added :)

shedaniel commented 3 years ago

No, then you made it worse. The dynamic registries system automatically adds your features to the registry, but it is not present in the biomes themselves.

Technici4n commented 3 years ago

That does not add it to biomes magically.