search

architv / soccer-cli

:soccer: Football scores for hackers. :computer: A command line interface for all the football scores.
MIT License
1.09k stars 222 forks source link

Fix whitespace issues and removed unused imports #112

Closed Saturn closed 7 years ago

Saturn commented 7 years ago

Remove unused imports, fixed a couple of lines that were too long...

Use absolute imports in test file.

There should be two blank lines between functions and a single blank line for class methods.

Also from PEP8:

Imports should be grouped in the following order:

- standard library imports
- related third party imports
- local application/library specific imports

You should put a blank line between each group of imports.
carlosvargas commented 7 years ago

Did we ever agree on which merge functionality we want to use? "Merge commit" vs "rebase" vs "squash"?

Saturn commented 7 years ago

Maybe when the PR has lots of tiny commits, it would make sense to squash them. Like sometimes when someone keeps adding little changes to a PR that is being reviewed. "Forgot a line break ... ", "tidying this up ..." etc

But if I'd have to pick an option to always use then I'd just stick with the merge commits.